-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.36] Fixes Listing tags in JFrog Artifactory may fail #5633
[release-1.36] Fixes Listing tags in JFrog Artifactory may fail #5633
Conversation
Addresses the problem first described in containers/skopeo#2346 Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ephemeral COPR build failed. @containers/packit-build please check. |
@lsm5 thoughts on the packit failures? |
I suspect it's something in the ELN-aarch64 env given it's only failing there and nowhere else. I've pinged them but feel free to ignore if we need to get this going. |
LGTM |
@Luap99 PTAL at failures |
I would assume you need to backport #5574 for test fixes |
64504c1
to
88b00f1
Compare
... for libnetwork Starting in common 0.59.1, github.com/containers/common's libnetwork no longer attempts to detect when it's running in a user namespace to decide where a lock file that it uses will be. Since this test is doing user namespace setup on its own as part of the test, we need to explicitly tell it to not use the one that belongs to the node's root user. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com> Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
As the title says Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
88b00f1
to
2d5c59a
Compare
A friendly reminder that this PR had no activity for 30 days. |
/lgtm |
5a161c8
into
containers:release-1.36
Addresses the problem first described in containers/skopeo#2346
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?