Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.36] Fixes Listing tags in JFrog Artifactory may fail #5633

Conversation

TomSweeneyRedHat
Copy link
Member

Addresses the problem first described in containers/skopeo#2346

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Addresses the problem first described in containers/skopeo#2346

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
Copy link
Contributor

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@TomSweeneyRedHat TomSweeneyRedHat added the No New Tests Allow PR to proceed without adding regression tests label Jul 17, 2024
@TomSweeneyRedHat
Copy link
Member Author

@lsm5 thoughts on the packit failures?

@lsm5
Copy link
Member

lsm5 commented Jul 18, 2024

@lsm5 thoughts on the packit failures?

I suspect it's something in the ELN-aarch64 env given it's only failing there and nowhere else. I've pinged them but feel free to ignore if we need to get this going.

@TomSweeneyRedHat
Copy link
Member Author

@lsm5 how can we move this forward at this point? Do I just ask for the merge hammer from @rhatdan ?

@lsm5
Copy link
Member

lsm5 commented Aug 8, 2024

@lsm5 how can we move this forward at this point? Do I just ask for the merge hammer from @rhatdan ?

there are no packit failures anymore. I hit the rerun button on failed cirrus tests just now.

@rhatdan
Copy link
Member

rhatdan commented Aug 9, 2024

LGTM

@rhatdan
Copy link
Member

rhatdan commented Aug 9, 2024

@Luap99 PTAL at failures

@Luap99
Copy link
Member

Luap99 commented Aug 9, 2024

I would assume you need to backport #5574 for test fixes

@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/jfrog-1.36 branch from 64504c1 to 88b00f1 Compare August 27, 2024 22:37
nalind and others added 2 commits September 12, 2024 20:22
... for libnetwork

Starting in common 0.59.1, github.com/containers/common's libnetwork no
longer attempts to detect when it's running in a user namespace to
decide where a lock file that it uses will be.  Since this test is doing
user namespace setup on its own as part of the test, we need to
explicitly tell it to not use the one that belongs to the node's root
user.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
As the title says

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
Copy link

A friendly reminder that this PR had no activity for 30 days.

@nalind
Copy link
Member

nalind commented Oct 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 24, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5a161c8 into containers:release-1.36 Oct 24, 2024
38 checks passed
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants