tests: set _CONTAINERS_USERNS_CONFIGURED=done for libnetwork #5574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting in common 0.59.1, github.com/containers/common's libnetwork no longer attempts to detect when it's running in a user namespace to decide where a lock file that it uses will be. Since this test is doing user namespace setup on its own as part of the test, we need to explicitly tell it to not use the one that belongs to the node's root user. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
/lgtm |
a7bc7b5
into
containers:main
34 of 36 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind other
What this PR does / why we need it:
Starting in common 0.59.1, github.com/containers/common's libnetwork no longer attempts to detect when it's running in a user namespace to decide where a lock file that it uses will be. Since this test is doing user namespace setup on its own as part of the test, we need to explicitly tell it to not use the one that belongs to the node's root user.
How to verify it
Updated integration test!
Which issue(s) this PR fixes:
Unblocks #5567.
Special notes for your reviewer:
Does this PR introduce a user-facing change?