[skip-ci] rpm: use go-rpm-macros supported vendoring #5410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need for any `Provides: bundled()` we needed in spec files. The updated Provides will be visible in the build logs and can also be verified with `rpm -q --provides $RPM_FILE`. Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need for any
Provides: bundled()we needed in spec files.The updated Provides will be visible in the build logs and can also be verified with
rpm -q --provides $RPM_FILE.What type of PR is this?
/kind other
What this PR does / why we need it:
fixes an rpm packaging issue
How to verify it
rpm -q --provides $GENERATED_RPMwill show you a list of bundled Provides. You can generate rpm withmake rpm.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?