fix /etc/hosts and resolv.conf setup with network configs #5409
Conversation
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Includes new pasta functionality. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
I got confused a bit there so make it clearer to readers that both are different. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
We should never configure the files before we setup the network as we are missing a lot of information. This is part 1 of the refactor where we split the functions between create/add entries part. See the following commit to actualy see how me make use of this. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Previously buildah may have created a incorrect hosts/resolv.conf file, when netavark, slirp4netns or pasta are used we have to actually consider their special setup and use the correct nameservers. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
No it doesn't, the only thing merged sine my changes is #5410 which doesn't cause any conflicts. |
@Luap99 Ah its the github UI then, i think it is just asking for a rebase with Anyways PR LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?