Shutdown nydusd if it serves no filesystem or snapshot #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 22, 2022
7159216 to
18f3822
Compare
Codecov ReportBase: 35.93% // Head: 35.95% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
==========================================
+ Coverage 35.93% 35.95% +0.02%
==========================================
Files 28 28
Lines 2858 2859 +1
==========================================
+ Hits 1027 1028 +1
- Misses 1724 1725 +1
+ Partials 107 106 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
imeoer
reviewed
Nov 25, 2022
pkg/filesystem/fs/fs.go
Outdated
|
|
||
| // Found shared daemon | ||
| // Fscache userspace daemon has no host mountpoint. | ||
| if d.HostMountpoint() == fs.rootMountpoint || fs.fsDriver == config.FsDriverFscache { |
There was a problem hiding this comment.
Maybe put it in a helper func.
There was a problem hiding this comment.
extracted a help function tryRetainSharedDaemon
imeoer
reviewed
Nov 25, 2022
pkg/filesystem/fs/fs.go
Outdated
|
|
||
| for _, d := range liveDaemons { | ||
| // Found shared daemon | ||
| if d.HostMountpoint() == fs.rootMountpoint || fs.fsDriver == config.FsDriverFscache { |
So the modules can rely on this to decide if stop nydusd daemon. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
As the snapshot and rafs intance is well managed now, we can easily umount a snapshot by its ID. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
We can reliably judege the recoverd daemon is shared one when its host mount point equals to the root mount point. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Stop the shared daemon when closing snapshotter if no snapshots is referenced to the shared daemon. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Beyond nydusd 2.1, data blob cache has a suffix .blob.data Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
So we can know more about nydusd and snapshots via management API. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Make the log lines more suggestive and clear. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
No need to use has_daemon to check. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
18f3822 to
cbe79da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sharedDaemon mode, we should also shut down the shared nydusd if it is not needed by any snapshot.
In addition, we should retain the shared daemon object in fs layer when doing recovery during nydus-snapshotter startup.