Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sharedMode snapshotter doesn't shutdown nydusd when handling os signal INT and TERM #135

Closed
changweige opened this issue Aug 16, 2022 · 1 comment
Labels

Comments

@changweige
Copy link
Member

changweige commented Aug 16, 2022

As a e2e test case comment says:

          # After the snapshotter container is stopped, it seems that Nydusd doesn't umount it
          # so we need to umount it here, otherwise you cannot delete this directory. 
          # Frankly, I don't know why Nydusd didn't clean up these resources.
          sudo umount -f /var/lib/containerd-test/io.containerd.snapshotter.v1.nydus/mnt

The reason is that nydus-snapshotter always forks a nydusd when starts but exits leaving the nydusd unsignaled.

In fact, we can't just terminate sharedMode nydusd when handling SIGINT and SIGTERM since it can still serve container images while restarting nydus-snapshotter. But we call terminate it when nydusd when snapshotter is aware that no container image is being served.

@changweige
Copy link
Member Author

will be addressed by #260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant