-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gomod] Deprecate the '--force-gomod-tidy' CLI flag #714
[gomod] Deprecate the '--force-gomod-tidy' CLI flag #714
Conversation
6156194
to
1d0dab1
Compare
With the Go 1.22 vendored workspaces out of the way, this is now rebased and ready for review to make progress with #707 which is a major issue since it only really exists with our Go backend even though Yarn backends are the only ones using temporary repo working copies at the moment. |
Fixes: bbd2428 Signed-off-by: Erik Skultety <eskultet@redhat.com>
Originally, the section in question was hosted under 'Vendoring' where it should have been under 'gomod flags'. This minor change is going to be even more emphasized with further deprecated gomod flags, like '--force-gomod-tidy' which future patches will deprecate. Signed-off-by: Erik Skultety <eskultet@redhat.com>
Specifically mention that they're bound to be removed in future releases and not to be kept around forever. Signed-off-by: Erik Skultety <eskultet@redhat.com>
This flag has always been documented as "questionable" and a candidate for a removal (documented by commit 9e9615c ) ever since its introduction. This patch officially deprecates the flag. Signed-off-by: Erik Skultety <eskultet@redhat.com>
Resolves: containerbuildsystem#713 Signed-off-by: Erik Skultety <eskultet@redhat.com>
1d0dab1
to
fc087e3
Compare
Just a note to myself, we'll need to mention this in the release notes as a breaking change because we won't be defaulting to the |
4af23d8
This deprecates the
--force-gomod-tidy
CLI option. Since this effort could result in a controversial breaking behaviour the first attempt is somewhat conservative in that it doesn't default to usinggo mod tidy
at all and instead ignores this aspect of a misconfigured repository.Relates to: #713
Maintainers will complete the following section
Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:
/ok-to-test
(as is the standard for Pipelines as Code)