-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the --force-gomod-tidy CLI flag #713
Labels
gomod
Pull requests/issues related to the gomod handling module
Comments
eskultety
added
the
gomod
Pull requests/issues related to the gomod handling module
label
Oct 25, 2024
eskultety
added a commit
to eskultety/cachi2
that referenced
this issue
Oct 25, 2024
4 tasks
eskultety
added a commit
to eskultety/cachi2
that referenced
this issue
Jan 7, 2025
eskultety
added a commit
to eskultety/cachi2
that referenced
this issue
Jan 7, 2025
Resolves: containerbuildsystem#713 Signed-off-by: Erik Skultety <eskultet@redhat.com>
eskultety
added a commit
to eskultety/cachi2
that referenced
this issue
Jan 8, 2025
Resolves: containerbuildsystem#713 Signed-off-by: Erik Skultety <eskultet@redhat.com>
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 8, 2025
Resolves: #713 Signed-off-by: Erik Skultety <eskultet@redhat.com>
Resolved in 4af23d8 -> closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running
go mod tidy
on the input source repository will result in dirtying the repo which is likely an undesirable effect that we should avoid doing. On the other hand, if we keep the flag and start running all operations on a temporary working copy of the repository the effect of the flag will be discarded with the working copy at the end offetch-deps
which may confuse our user base.The good thing is that we even documented (https://github.com/containerbuildsystem/cachi2/blob/main/docs/gomod.md#--force-gomod-tidy) the flag as questionable, warning users it may be dropped in the future. The time has come now that we should improve our game and mandate a temporary working copy of the input repository for all pkg mgr backends.
Blocks:
The text was updated successfully, but these errors were encountered: