Burn-in constructor version into installers #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaimergp
reviewed
Jan 24, 2023
jaimergp
reviewed
Jan 24, 2023
jaimergp
reviewed
Jan 24, 2023
jaimergp
reviewed
Jan 25, 2023
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
jaimergp
approved these changes
Jan 25, 2023
|
Downloaded all installers and checked them. They all have the data correctly burned-in. On macOS also this works: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Having the constructor version burned into the installers allows to better support faulty installers by knowing from which version of constructor they originate from. The version makes it clear if it is a released version or a canary release.
closes #604
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?