Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark skeleton for deprecation. #4886

Closed
wants to merge 32 commits into from
Closed

Mark skeleton for deprecation. #4886

wants to merge 32 commits into from

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented May 16, 2023

Description

This follows more or less the same pattern as #4645. Fixes #4640.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • [ ] Add / update necessary tests?
  • [ ] Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label May 16, 2023
@jezdez jezdez requested a review from kenodegard May 16, 2023 15:45
@dholth
Copy link
Contributor

dholth commented May 16, 2023

Seems pretty simple, straightforward.

jezdez and others added 4 commits May 16, 2023 17:52
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
@jezdez
Copy link
Member Author

jezdez commented May 16, 2023

pre-commit.ci autofix

@jezdez jezdez modified the milestone: 3.25.0 May 22, 2023
@jezdez jezdez requested review from kenodegard and beeankha June 5, 2023 12:00
travishathaway
travishathaway previously approved these changes Jun 5, 2023
Copy link
Contributor

@travishathaway travishathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

beeankha
beeankha previously approved these changes Jun 5, 2023
@jezdez jezdez dismissed stale reviews from beeankha and travishathaway via b2c4098 June 6, 2023 06:55
jezdez and others added 3 commits June 6, 2023 08:55
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
@jezdez jezdez requested a review from kenodegard June 6, 2023 06:57
@dbast
Copy link
Member

dbast commented Jun 6, 2023

Are we sure we really want to deprecate the cran skeleton already?

@jezdez
Copy link
Member Author

jezdez commented Jun 6, 2023

Are we sure we really want to deprecate the cran skeleton already?

For the record, this change does not deprecate skeleton but simply marks the code as pending deprecation, meaning that we intend to deprecate it in the future. We've set the time of deprecation to happen in the 4.0.0 release (currently).

Note
We've discussed adopting CEP 8 and CEP 9 for conda-build as well, so that the version number might change to the applicable version number, when we adopt them. But then the same practice applies: "pending deprecation" means "far in the future", and enough time to evolve the code and work on grayskull.

This change will provide both maintainers and users a predictable time window to solve the issues listed above by working with @marcelotrevisani and @bgruening (et al) to update grayskull. The alternative is an endless hand-wringing about how we can overcome the maintenance issues in skeleton.

If Anaconda is intending to use skeleton for the next cran build out, they may still do that a) until 4.0.0 is released (if they have to upgrade) or b) by using an older version of conda-build.

Of course, I hope by then we'll have enough Anaconda build engineers contribute actively to grayskull 😃

@kenodegard
Copy link
Contributor

before we proceed with marking this for deprecation I'd like to see a conda-skeleton vs. grayskull comparison table and a promise to support the missing features in the near future

perhaps it's more appropriate to deprecate the functionality of conda-skeleton that grayskull already does but still keep the stuff that has not been implemented yet?

@ForgottenProgramme
Copy link
Contributor

ForgottenProgramme commented Jun 8, 2023

@kenodegard, this blog post has a grayskull vs conda-skeleton comparision table which was based off of the comparision provided here.

Copy link

github-actions bot commented Jun 8, 2024

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

1 similar comment
Copy link

github-actions bot commented Jun 8, 2024

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Jun 8, 2024
@github-actions github-actions bot added the stale::closed [bot] closed after being marked as stale label Jul 8, 2024
@github-actions github-actions bot closed this Jul 8, 2024
@github-actions github-actions bot added stale::recovered [bot] recovered after being marked as stale and removed stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA stale::recovered [bot] recovered after being marked as stale
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Mark conda-build skeleton as "Pending deprecation"
8 participants