-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark skeleton for deprecation. #4886
Conversation
Seems pretty simple, straightforward. |
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
…o deprecate-skeleton
pre-commit.ci autofix |
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
for more information, see https://pre-commit.ci
…o deprecate-skeleton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
Are we sure we really want to deprecate the cran skeleton already?
|
For the record, this change does not deprecate skeleton but simply marks the code as pending deprecation, meaning that we intend to deprecate it in the future. We've set the time of deprecation to happen in the 4.0.0 release (currently).
This change will provide both maintainers and users a predictable time window to solve the issues listed above by working with @marcelotrevisani and @bgruening (et al) to update grayskull. The alternative is an endless hand-wringing about how we can overcome the maintenance issues in skeleton. If Anaconda is intending to use skeleton for the next cran build out, they may still do that a) until 4.0.0 is released (if they have to upgrade) or b) by using an older version of conda-build. Of course, I hope by then we'll have enough Anaconda build engineers contribute actively to grayskull 😃 |
before we proceed with marking this for deprecation I'd like to see a perhaps it's more appropriate to deprecate the functionality of |
@kenodegard, this blog post has a |
Hi there, thank you for your contribution! This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs. If you would like this pull request to remain open please:
NOTE: If this pull request was closed prematurely, please leave a comment. Thanks! |
1 similar comment
Hi there, thank you for your contribution! This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs. If you would like this pull request to remain open please:
NOTE: If this pull request was closed prematurely, please leave a comment. Thanks! |
Description
This follows more or less the same pattern as #4645. Fixes #4640.
Checklist - did you ...
news
directory (using the template) for the next release's release notes?[ ] Add / update necessary tests?[ ] Add / update outdated documentation?