Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace conda_build/index.py with standalone conda-index #4645

Closed
6 tasks done
Tracked by #4697
dholth opened this issue Nov 22, 2022 · 2 comments · Fixed by #4828
Closed
6 tasks done
Tracked by #4697

Replace conda_build/index.py with standalone conda-index #4645

dholth opened this issue Nov 22, 2022 · 2 comments · Fixed by #4828
Assignees
Labels
backlog issue has been triaged but has not been earmarked for any upcoming release in-progress issue is actively being worked on locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc. type::feature request for a new feature or capability

Comments

@dholth
Copy link
Contributor

dholth commented Nov 22, 2022

Checklist

  • I added a descriptive title
  • I searched open requests and couldn't find a duplicate

What is the idea?

conda-build generates repodata.json during its run, using get_build_index https://github.com/conda/conda-build/blob/main/conda_build/index.py#L112

This confusing function both downloads repodata.json, and generates new repodata.json for the local package cache / the packages that were just built.

It also provides the "conda-build index" command line interface, or "conda index".

Now that we have a much faster standalone conda-index descended from conda_build/index.py, conda-build should add a dependency on conda-index, and call that instead. (The downloading parts of get_build_index will probably have to stay)

  • package conda-index
  • figure out what to do about the new CLI "conda index" (provided by standalone conda-index) versus the old CLI "conda index" provided by conda-build
  • depend on conda-index
  • rewrite get_build_index

Why is this needed?

This will ensure that we have one excellent repodata.json generator.

What should happen?

No response

Additional Context

No response

@dholth dholth added type::feature request for a new feature or capability backlog issue has been triaged but has not been earmarked for any upcoming release labels Nov 22, 2022
@dholth
Copy link
Contributor Author

dholth commented Jan 4, 2023

Confusingly get_build_index is mostly about getting a list of available packages, not about creating an index, so we keep get_build_index and call conda_index's update_index() appropriately.

@travishathaway travishathaway added the source::anaconda created by members of Anaconda, Inc. label Jan 18, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in 🧭 Planning Feb 24, 2023
@dholth
Copy link
Contributor Author

dholth commented Mar 9, 2023

Tried again in #4798

@dholth dholth moved this from 🆕 New to 👀 In Review in 🧭 Planning Mar 9, 2023
@dholth dholth added the in-progress issue is actively being worked on label Mar 9, 2023
@dholth dholth linked a pull request Mar 9, 2023 that will close this issue
3 tasks
@github-project-automation github-project-automation bot moved this from 👀 In Review to 🏁 Done in 🧭 Planning May 16, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label May 16, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backlog issue has been triaged but has not been earmarked for any upcoming release in-progress issue is actively being worked on locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc. type::feature request for a new feature or capability
Projects
Archived in project
3 participants