Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: rerender #6

Merged
merged 6 commits into from
Nov 24, 2024
Merged

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #5.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

Fixes #5

@conda-forge-admin
Copy link
Contributor Author

conda-forge-admin commented Nov 24, 2024

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11994027595. Examine the logs at this URL for more detail.

@conda-forge-admin conda-forge-admin marked this pull request as ready for review November 24, 2024 05:02
@h-vetinari
Copy link
Member

error: identifier "FLT_MAX" is undefined

Found that xgboost had had the same problem, which needed dmlc/xgboost#10574

@h-vetinari
Copy link
Member

h-vetinari commented Nov 24, 2024

@hmaarrfk, just saw your comment in #5:

For pytorch 2.5.1

Interestingly, the migrator still shows torchaudio as "Awaiting parents"; this could be due to regro/cf-scripts#3191 (and the bot not yet having retried torchaudio since that was fixed). In any case, aside the linter failure that I don't think is due to this PR (conda-forge/conda-smithy#2165), we can merge this IMO, as it's a necessary clean-up anyway.

h-vetinari added a commit that referenced this pull request Nov 24, 2024
@h-vetinari h-vetinari merged commit 345fbe6 into conda-forge:main Nov 24, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin please rerender
2 participants