Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py313 migration stuck on networkx - wrongly still "Awaiting parents"? #3191

Closed
h-vetinari opened this issue Nov 22, 2024 · 3 comments
Closed

Comments

@h-vetinari
Copy link
Contributor

The 3.13 migration has networkx as the top missing dependency, yet, paradoxically, as still "Awaiting parents". I've checked the "Done" feedstocks as well for whether they're parents of networkx (and whether they were built without spurious CI failures), but I cannot tell where this is hanging.

The problem is that even a manual PR to networkx will fix this, as the bot still thinks it needs to wait for something.

CC @beckermr

@beckermr
Copy link
Contributor

Hrmmmm ok. We need to check the node attrs and see what they look like. Could be a v1 parsing error.

@beckermr
Copy link
Contributor

beckermr commented Nov 22, 2024

I think the issue is here: https://github.com/regro/cf-scripts/blob/main/conda_forge_tick/migrators/migration_yaml.py#L615

It appears that v1 recipes parsed by rattler build do not come out with the outputs build section filled in. On networkx, the output has a build section of null in the json and so the output is wrongly assumed to not be noarch.

What is the semantics for v1 recipes? Does the parent build section get overrides from the outputs and then get used for the output? We can add w/e logic is correct to the function.

@h-vetinari
Copy link
Contributor Author

What is the semantics for v1 recipes? Does the parent build section get overrides from the outputs and then get used for the output? We can add w/e logic is correct to the function.

Pinging @wolfv @baszalmstra @nichmor :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants