Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RISE recipe #5098

Closed
wants to merge 3 commits into from
Closed

Add RISE recipe #5098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ade1cec
Add RISE recipe
astrojuanlu Feb 6, 2018
b97a873
Add summary and description
astrojuanlu Feb 6, 2018
43dbb57
Remove build command to use OS specific scripts
Feb 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions recipes/rise/bld.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
"%PYTHON%" setup.py install
"%PREFIX%\Scripts\jupyter-nbextension.exe" install rise --py --sys-prefix
if errorlevel 1 exit 1
2 changes: 2 additions & 0 deletions recipes/rise/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
"${PYTHON}" setup.py install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not for now... but in the future we should think if this is the proper incantation, check #528 for a long discussion about that...

"${PREFIX}/bin/jupyter-nbextension" install rise --py --sys-prefix
44 changes: 44 additions & 0 deletions recipes/rise/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
{% set name = "rise" %}
{% set version = "5.2.0" %}
{% set sha256 = "514eb8784b8d4f7c2af4ba77055fd7a7d8365a87e55eb118d2f7a3ea400dbd7b" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
fn: {{ name }}-{{ version }}.tar.gz
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
sha256: {{ sha256 }}

build:
noarch: python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an important change compared with the current situation where I create pkgs for each architecture.
We need extensive testing to know if we don't have problems in any of the architectures we supported.
But I am +1 on this change unless we see associated problems, it simplifies things... and conda 4.3 is old enough by now...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm not sure if noarch should be there, since there are different build scripts for each operative systems. Thoughts @conda-forge/core?

number: 0

requirements:
build:
- python
- notebook >=5.0.0
run:
- python
- notebook >=5.0.0

test:
requires:
- python
- notebook >=5.0.0

about:
home: https://github.com/damianavila/RISE
license: BSD 3-Clause
license_file: LICENSE.md
summary: 'Reveal.js - Jupyter/IPython Slideshow Extension'
description: |
Reveal.js - Jupyter/IPython Slideshow Extension, also known as live_reveal.
Quickly turn your Jupyter Notebooks into a live presentation.


extra:
recipe-maintainers:
- Juanlu001
- damianavila
2 changes: 2 additions & 0 deletions recipes/rise/post-link.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
"%PREFIX%\Scripts\jupyter-nbextension.exe" enable rise --py --sys-prefix
if errorlevel 1 exit 1
1 change: 1 addition & 0 deletions recipes/rise/post-link.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
"${PREFIX}/bin/jupyter-nbextension" enable rise --py --sys-prefix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for now but when damianavila/RISE#342 lands, we should modify and delete this post steps, because there will be no needed anymore...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, we can update the recipe after that :)

2 changes: 2 additions & 0 deletions recipes/rise/pre-unlink.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
"%PREFIX%\Scripts\jupyter-nbextension" disable rise --py --sys-prefix
if errorlevel 1 exit 1
1 change: 1 addition & 0 deletions recipes/rise/pre-unlink.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
"${PREFIX}/bin/jupyter-nbextension" disable rise --py --sys-prefix
1 change: 1 addition & 0 deletions recipes/rise/run_test.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
"%PREFIX%\python.exe" -c "print('placeholder')"
1 change: 1 addition & 0 deletions recipes/rise/run_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
"${PREFIX}/bin/python" -c "print('placeholder')"