-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RISE recipe #5098
Add RISE recipe #5098
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/rise:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
sha256: {{ sha256 }} | ||
|
||
build: | ||
noarch: python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an important change compared with the current situation where I create pkgs for each architecture.
We need extensive testing to know if we don't have problems in any of the architectures we supported.
But I am +1 on this change unless we see associated problems, it simplifies things... and conda 4.3 is old enough by now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I'm not sure if noarch
should be there, since there are different build scripts for each operative systems. Thoughts @conda-forge/core?
@@ -0,0 +1,2 @@ | |||
"${PYTHON}" setup.py install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not for now... but in the future we should think if this is the proper incantation, check #528 for a long discussion about that...
@@ -0,0 +1 @@ | |||
"${PREFIX}/bin/jupyter-nbextension" enable rise --py --sys-prefix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for now but when damianavila/RISE#342 lands, we should modify and delete this post steps, because there will be no needed anymore...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, we can update the recipe after that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, but LGTM.
I think this was superseded by https://github.com/conda-forge/rise-feedstock (by @ocefpaf). |
Oops, I was too slow on this one :) Closing! |
Actually it was not me who added that to conda-forge ;-) |
I copied the original recipe from @damianavila with minimal changes. Damián, I added you as a maintainer in case you want to be notified with changes but please don't hesitate to step down, I can take care of the conda-forge recipe if you want :)