-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using commit hash instead of master #3
Conversation
Not sure what is going on with
|
Same failure trying to check the released version 😒 |
fd860e2
to
1b5e4c0
Compare
@msarahan do you have any idea if there is something wrong with the recipe or if this is a |
Sorry, no ideas right off the bat. @stuarteberg might have some ideas. He has been pretty deeply involved in that bit of conda-build. |
Thanks @msarahan! |
I'm away from my computer until Tuesday. |
3af097d
to
6005958
Compare
I can reproduce this @ocefpaf. Just update your docker image. The problem is that we have the latest releases of all of the build tools (including conda-build) and we have found a bug (or we've configured in some way that wasn't previously supported). |
Maybe we should pin to an old conda-build until this is resolved? |
I must be doing something wrong because I tried to downgrade conda-build and that did not work. I also pulled the docker image yesterday! Let me try again here to see what I am doing wrong. |
@pelson with the commands docker pull pelson/obvious-ci:latest_x64
docker run -it --rm -v $(pwd):/home/ pelson/obvious-ci:latest_x64 /bin/sh
conda update --all --yes
conda build home I cannot reproduce the issue. And here is the conda info output: platform : linux-64
conda version : 4.0.5
conda-build version : 1.20.0
python version : 3.5.1.final.0
requests version : 2.9.1
root environment : /opt/conda (writable)
default environment : /opt/conda
envs directories : /opt/conda/envs
package cache : /opt/conda/pkgs
channel URLs : https://repo.continuum.io/pkgs/free/linux-64/
https://repo.continuum.io/pkgs/free/noarch/
https://repo.continuum.io/pkgs/pro/linux-64/
https://repo.continuum.io/pkgs/pro/noarch/
config file : /root/.condarc
is foreign system : False Also, this packaged built just fine in staged recipes with |
A bit of background: when checking the git revision of a package, conda-build runs a couple git commands, including $ cd /miniconda/conda-bld/work
$ git remote -v
origin /miniconda/conda-bld/git_cache/Users_bergs_Documents_mypackage (fetch)
origin /miniconda/conda-bld/git_cache/Users_bergs_Documents_mypackage (push) It parses the (PS -- The recently-merged conda/conda-build#801 still includes the above-mentioned assertion, so it won't fix the issue you saw here.) |
Thanks for the explanation @stuarteberg.
Not sure as that only happens when running the CI. Everything works when I build it locally with the same docker image. @pelson any ideas? Could it be how we mount the volumes? |
|
OK, I didn't know that conda-build's root directory was configurable via conda-build:
root-dir: /feedstock_root/build_artefacts That means the assertion I referred to above isn't actually valid. It will be removed via conda/conda-build#855. |
Closes #2