Improved the use of whitespace in templates. #100
Conversation
| @@ -38,18 +41,17 @@ echo "$config" > ~/.condarc | |||
| conda clean --lock | |||
|
|
|||
| conda update --yes --all | |||
|
|
|||
| conda install --yes conda-build==1.18.2 | |||
There was a problem hiding this comment.
Also, note this change @ocefpaf.
There was a problem hiding this comment.
Thanks. That bug does not occur in all feedstocks, but I guess it is safer this way until it gets fixed.
There was a problem hiding this comment.
I have looked a bit closer and I believe the problem was an issue with an assertion in conda-build. See this comment. Please correct me if I am missing something here, @pelson and @ocefpaf.
It appears like this PR ( conda/conda-build#855 ) fixes the assertion issue. Assuming that does fix the problem, that change is in the 1.20.1 release.
Though I'm not sure whether we can use it or not yet as we have this issue ( conda/conda-build#889 ) on Mac and conceivably it would be present on Linux too. We believe this is fixed in this PR ( conda/conda-build#892 ), but are still waiting for a release.
There was a problem hiding this comment.
Sounds good to me. It would be great if every workaround is commented with links to related issues/PRs right in the sources, so it is obvious what was wrong with it and when it is safe to remove the workaround. I am maintaining our company's recipes and I know that almost every release of Conda/Conda-Build breaks something somewhere in an unexpected way, this is why I asked what is wrong with all newer Conda-Build releases after 1.18.2.
There was a problem hiding this comment.
Looks like we might be able to drop it after all. See this PR ( #152 ).
There was a problem hiding this comment.
We have dropped this pinning in master and it will be gone in the next release.
Drop the `gcc` package
|
cc @frol |
No description provided.