Updated recipe/meta.yaml to version 3.36.0 #19

jochym · 2017-11-09T14:16:21Z

No description provided.

conda-forge-linter · 2017-11-09T14:16:25Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jochym · 2017-11-09T14:32:18Z

@DRMacIver - here is a link to the log for 3.6 on linux:
https://circleci.com/gh/jochym/hypothesis-feedstock/126?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Would you care to take a look? Start at the end - it fails to import hypothesis.searchstrategy :
ModuleNotFoundError: No module named 'hypothesis.searchstrategy'

Even better is the last build:
https://circleci.com/gh/jochym/hypothesis-feedstock/126?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

conda-forge-linter · 2017-11-09T14:36:19Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe (might be a conda-smithy bug) 😢

conda-forge-linter · 2017-11-09T14:38:14Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

DRMacIver · 2017-11-09T15:38:05Z

@jochym I really can't see anything obviously wrong here. In particular it's very strange for hypothesis and hypothesis.extra to import correctly and hypothesis.searchstrategy not.

My guess is that this problem must be somewhere in your build setup rather than Hypothesis because I've never seen this problem outside of conda (including a bunch of other downstream packagers), but I've no idea what that could be! Can you give me any pointers on how to reproduce this problem locally to debug?

jochym · 2017-11-09T16:03:03Z

Ok. This at least means that I am not doing something obviously wrong. I'll try to make a local version of the build/error for you to test.

DRMacIver · 2017-11-09T16:06:18Z

This at least means that I am not doing something obviously wrong.

At least not obvious to me. I want to reemphasise that I know remarkably little about conda packaging!

jochym · 2017-11-10T15:08:17Z

I have found at least one problem - the build dependence on attrs is circular. I think the package for attrs should move hypothesis dependency to testin requirements. I have submitted the PR to this effect (conda-forge/attrs-feedstock#6), but it will take some time to get accepted.
On my local system the package builds properly and imports work again. @DRMacIver would you review test section of the recipe/meta.yaml to make sure the imports which are supposed to work are there and the tests are executed in the way they are supposed to work?

DRMacIver · 2017-11-10T15:06:40Z

recipe/meta.yaml

-      #        - cd git_src
-      #        - python -m pytest tests/cover
+    - hypothesis.searchstrategy
+#    - hypothesis.tools


BTW this package is actually gone, so any failures to import it are genuine.

DRMacIver · 2017-11-10T15:11:37Z

recipe/meta.yaml

+  commands:
+    - git clone https://github.com/HypothesisWorks/hypothesis-python.git src
+    - cd src
+    - bash scripts/basic-test.sh


You might want to not use this - it has a lot of reliance on pip to manage installs as it runs the tests.

DRMacIver · 2017-11-10T15:12:18Z

recipe/meta.yaml

+#    - python -m pytest tests/cover
+#    - python -m pytest tests/datetime
+#    - python -m pytest tests/fakefactory
+#    - python -m pytest tests/pytest -p pytester --runpytest subprocess


If you restore these it might be worth adding tests for the tests/numpy and tests/pandas sections too, given conda's user demographics! Both of those would then have to be added as testing dependencies.

Ok. I switched the tests and made it to:

- python -m pytest tests/cover - python -m pytest tests/datetime - python -m pytest tests/fakefactory - python -m pytest tests/numpy - python -m pytest tests/pandas - python -m pytest tests/py2 # [py2k] - python -m pytest tests/py3 # [py3k] - python -m pytest tests/pytest -p pytester --runpytest subprocess

Is this supposed to work?

Yes, that should work (except for comment about pytest-xdist elsewhere)

DRMacIver · 2017-11-10T15:13:32Z

recipe/meta.yaml

-        #  requires:
-        #    - pytest
+  requires:
+    - pytest
  imports:
    - hypothesis
    - hypothesis.extra


I'm not totally clear on what the imports tests are for, but might it be worth switching these to correspond more to which ones are in the public API? That would probably be:

hypothesis

hypothesis.extra

hypothesis.strategies (note: not the same as hypothesis.searchstrategy)

hypothesis.stateful

The others that are currently there are mostly internal packages.

Done all above. Thanks - let us wait for the results of CI.

DRMacIver · 2017-11-10T15:14:44Z

recipe/meta.yaml

-        #  requires:
-        #    - pytest
+  requires:
+    - pytest


If you move away from using the basic-test.sh then the following are probably also useful testing requirements:

pytz

numpy

pandas

faker

Sorry a thing that I've just noticed will probably give you trouble: I think pytest-xdist should also be a testing dependency - otherwise when you run pytest in the testing section it will pick up the "-n 2" flag from the tox.ini and won't recognise it.

(If you want to disable it running in parallel you can then pass "-n 0" to pytest to override)

https://circleci.com/gh/jochym/hypothesis-feedstock/152

python -m pytest tests/cover
usage: pytest.py [options] [file_or_dir] [file_or_dir] [...]
pytest.py: error: unrecognized arguments: -n
inifile: /feedstock_root/build_artefacts/hypothesis_1510330029786/test_tmp/src/tox.ini
rootdir: /feedstock_root/build_artefacts/hypothesis_1510330029786/test_tmp/src
TESTS FAILED: hypothesis-3.36.0-py36_0.tar.bz2

I have added pytest-xdist to the dependencies.

Sorry, I forgot about flaky. That also needs to be in the testing dependencies.

DRMacIver · 2017-11-10T15:15:43Z

recipe/meta.yaml

@@ -12,34 +12,39 @@ source:
  sha256: {{ sha256 }}

 build:
-  skip: True  # [py<34]


Depending on which versions of Python are currently supported in conda you may need to restrict this further (all of the ones in your actual CI are fine though)

DRMacIver · 2017-11-10T17:45:42Z

Looking at your failing tests:

I think the failure on Python 2 is a bug in the faker packaging for conda. It should be installing an ipaddress backport under Python 2. That being said it looks like it is meant to based on the run dependencies: https://github.com/conda-forge/faker-feedstock/blob/master/recipe/meta.yaml#L31
No idea what's going on with the xdist error on Python 3.5. FWIW if you don't want to debug, just passing "-n 0" to each pytest command will make those go away by turning off xdist.

jochym · 2017-11-10T18:46:52Z

OK, Thanks @DRMacIver - it looks like we have done it.
Any additional tests we should add to the package?
BTW: To respond to your earlier question - imports just test if the package is properly visible after install.

DRMacIver · 2017-11-10T21:15:15Z

recipe/meta.yaml

+    - faker
+    - mock
+    - flaky
+    - ipaddress  # [py2k]


Hmm is this a workaround? Because really this should be installed as part of the faker dependency.

DRMacIver · 2017-11-10T21:15:55Z

Any additional tests we should add to the package?

No, this looks good to me.

jochym · 2017-11-11T10:02:22Z

Thanks @DRMacIver for your help!

Updated recipe/meta.yaml to version 3.36.0

2b4392e

jochym mentioned this pull request Nov 9, 2017

Staying current with Hypothesis releases #8

Closed

jochym added 2 commits November 9, 2017 15:22

Add coverage to run deps

58e009c

Try to switch the testing on

8e4ec04

jochym changed the title ~~Updated recipe/meta.yaml to version 3.36.0~~ WIP: Updated recipe/meta.yaml to version 3.36.0 Nov 9, 2017

Switch on py27

9087092

Correct indents

e5b874e

jochym added 4 commits November 9, 2017 16:05

Use source_files for tests copying. Update tests based on upstream data

eeed29c

Spec of test dir

9e1d159

Debug test dir

3a4a430

Add scripts to testing setup

04d2473

jochym added 2 commits November 9, 2017 17:30

Try to debug

81de4a5

Eliminate circular deps via attrs

5e64538

DRMacIver reviewed Nov 10, 2017

View reviewed changes

jochym added 3 commits November 10, 2017 16:31

Update tests

6ec5c74

Add pytest-xdist to deps

82d9e55

Add mock flaky to deps

1275efe

Add ipaddress to deps for py27

fd8cb62

jochym added 3 commits November 10, 2017 19:15

Add blocking parallel tests.

60038d7

Parametrize tests

b2763c2

Remove unnecessary build deps

8bb6311

DRMacIver reviewed Nov 10, 2017

View reviewed changes

Drop pytest, pytest-xdist implies pytest

57f46a4

jochym changed the title ~~WIP: Updated recipe/meta.yaml to version 3.36.0~~ Updated recipe/meta.yaml to version 3.36.0 Nov 10, 2017

jochym merged commit 0d00a87 into conda-forge:master Nov 11, 2017

jochym mentioned this pull request Nov 11, 2017

Second attempt at fixing the broken package #18

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated recipe/meta.yaml to version 3.36.0 #19

Updated recipe/meta.yaml to version 3.36.0 #19

jochym commented Nov 9, 2017

conda-forge-linter commented Nov 9, 2017

jochym commented Nov 9, 2017 •

edited

Loading

conda-forge-linter commented Nov 9, 2017

conda-forge-linter commented Nov 9, 2017

DRMacIver commented Nov 9, 2017

jochym commented Nov 9, 2017

DRMacIver commented Nov 9, 2017

jochym commented Nov 10, 2017

DRMacIver Nov 10, 2017

DRMacIver Nov 10, 2017

DRMacIver Nov 10, 2017

jochym Nov 10, 2017

DRMacIver Nov 10, 2017

DRMacIver Nov 10, 2017

jochym Nov 10, 2017

DRMacIver Nov 10, 2017

DRMacIver Nov 10, 2017

DRMacIver Nov 10, 2017

jochym Nov 10, 2017

jochym Nov 10, 2017

DRMacIver Nov 10, 2017

DRMacIver Nov 10, 2017

DRMacIver commented Nov 10, 2017

jochym commented Nov 10, 2017

DRMacIver Nov 10, 2017

DRMacIver commented Nov 10, 2017

jochym commented Nov 11, 2017

Updated recipe/meta.yaml to version 3.36.0 #19

Updated recipe/meta.yaml to version 3.36.0 #19

Conversation

jochym commented Nov 9, 2017

conda-forge-linter commented Nov 9, 2017

jochym commented Nov 9, 2017 • edited Loading

conda-forge-linter commented Nov 9, 2017

conda-forge-linter commented Nov 9, 2017

DRMacIver commented Nov 9, 2017

jochym commented Nov 9, 2017

DRMacIver commented Nov 9, 2017

jochym commented Nov 10, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DRMacIver commented Nov 10, 2017

jochym commented Nov 10, 2017

Choose a reason for hiding this comment

DRMacIver commented Nov 10, 2017

jochym commented Nov 11, 2017

jochym commented Nov 9, 2017 •

edited

Loading