Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move hypothesis dependence to testing #6

Merged
merged 6 commits into from
Nov 10, 2017

Conversation

jochym
Copy link
Contributor

@jochym jochym commented Nov 10, 2017

This is an attempt to break circular dependency on hypothesis

This is an attempt to break circular dependency on hypothesis
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@CJ-Wright
Copy link
Member

@jochym Feel free to add yourself to the maintainers if you want.

@@ -55,3 +55,4 @@ extra:
- CJ-Wright
- licode
- nicoddemus
- jochym
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicoddemus
Copy link
Member

Thanks @jochym!

Actually I just realized that none of the dependencies in requirements/run are needed, they are all test dependencies only.

Would you mind moving the other dependencies as well? Also this is a perfect candidate for a noarch package, but I will ask for the bot to rerender for us.

@nicoddemus
Copy link
Member

@conda-forge-admin, please add noarch: python

@nicoddemus
Copy link
Member

... but I will ask for the bot to rerender for us.

What a time to be alive! 😄

@nicoddemus
Copy link
Member

@jochym please also bump the build number. 👍

@jochym
Copy link
Contributor Author

jochym commented Nov 10, 2017

Merge?

Copy link
Member

@CJ-Wright CJ-Wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicoddemus
Copy link
Member

Awesome @jochym, thanks!

@nicoddemus nicoddemus merged commit b2020bb into conda-forge:master Nov 10, 2017
@jakirkham
Copy link
Member

jakirkham commented Jul 11, 2018

Unfortunately we need to revert the conversion to noarch: python as this is a dependency of conda.

xref: regro/cf-scripts#264
xref: regro/cf-scripts#265
xref: conda-forge/conda-smithy#643
xref: conda-forge/requests-feedstock#23

@jochym
Copy link
Contributor Author

jochym commented Jul 11, 2018

Why @jakirkham ? I do not get it. Care to explain to us mere mortals? No sarcasm, I genuinely do not understand the dependence. I would appreciate getting some clue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants