Revert PR 404 #405
Merged
Revert PR 404 #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20bc339 to
7060ef7
Compare
|
It is not necessary! Please read #404. Anyways I will keep using my forked version as you clearly don't accept anything 😒 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts PR ( #404 ).
As mentioned in this comment, this path hack was found necessary in PR ( conda-forge/staged-recipes#982 ) to update
condato a recent enough working version so that activation would work.While I'm open to discussing and exploring how to do this in a cleaner in better way, it still remains necessary AFAICT. Any clean up of this should come with a demonstration of how it worked so that it can be more fully discussed.
cc @pelson @ocefpaf