Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no need for this change. #404

Merged
merged 1 commit into from
Jan 2, 2017
Merged

There is no need for this change. #404

merged 1 commit into from
Jan 2, 2017

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Jan 2, 2017

I've been re-rendering without this PATH dance and everything works just fine in AppVeyor.

@ocefpaf ocefpaf merged commit 5150383 into conda-forge:master Jan 2, 2017
@ocefpaf ocefpaf deleted the no_mess branch January 2, 2017 12:41
@jakirkham
Copy link
Member

Actually there was a purpose to this path manipulation. It is necessary due to the preincluded conda on AppVeyor being too old in some cases. To actually update conda we required these manipulations as activation did not work properly with some of the older conda's. Please see PR ( conda-forge/staged-recipes#982 ) for details. For now I'm going to revert this change. However, I'm open to discussing a cleaner strategy for solving this problem.

@jakirkham jakirkham mentioned this pull request Jan 3, 2017
Merged
@jakirkham
Copy link
Member

cc @pelson

@ocefpaf
Copy link
Member Author

ocefpaf commented Jan 3, 2017 •
edited
Loading

Actually there was a purpose to this path manipulation. It is necessary due to the preincluded conda on AppVeyor being too old in some cases.

No it is not. You need to update yourself and trust other people. It has been really hard to work you like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ocefpaf @jakirkham