Fix permissions #335
Merged
Fix permissions #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci_support/run_docker_build.sh|
Pulled in changes from PR ( #331 ) into this one and closed that PR out. |
|
Putting this in to handle some funky permissions issues we have run into. This primarily useful for local work. Mainly on Windows or when interacting with a Windows backed file system (e.g. VMs with shared directories). Shouldn't have any effect on our automation bots that are already on Linux and thus track permissions the same way git does anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds executable permissions to
ci_support/checkout_merge_commit.shin a few places. It should have them anyways because the file already has executable permissions. However, there are some oddities on Windows that need to be addressed.Also makes sure executable permissions are added for everyone, group, and user on both
ci_support/checkout_merge_commit.shandci_support/run_docker_build.sh. We were just adding executable permissions for the user before however it seemsos.chmodconferred them to group and everyone anyways. This appears to be inadvertent AFAICT. So we now do explicitly in this PR.