Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Run with bash explicitly #332

Closed
wants to merge 1 commit into from

Conversation

jakirkham
Copy link
Member

Fixes #330

Sometimes weird things happen and these scripts don't have executable permissions. This could be due to subtleties when working with VMs and/or Windows. To avoid everything going pear-shaped, don't assume these scripts have the right permissions and just run them through bash.

@jakirkham
Copy link
Member Author

I don't think this is necessary in light of PR ( #335 ) and PR ( #336 ) in particular. Though I need to get feedback from more users before I can say. In any event, let's hold off on this for the time being.

@jakirkham
Copy link
Member Author

It looks like PR ( #336 ) has fixed the underlying issue. Going to close this out for now. If we determine it is still needed, we can always reopen.

@jakirkham jakirkham closed this Oct 29, 2016
@jakirkham jakirkham deleted the exe_fallback branch October 29, 2016 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant