Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerender #86

Merged
merged 2 commits into from
Dec 29, 2024
Merged

Rerender #86

merged 2 commits into from
Dec 29, 2024

Conversation

h-vetinari
Copy link
Member

No description provided.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12408177765. Examine the logs at this URL for more detail.

@ilya-lavrenov
Copy link

Can we merge it?

@h-vetinari
Copy link
Member Author

Was waiting for input from @xhochy here (due to observed issues with abseil & clang 18). From my POV this should be good.

@h-vetinari
Copy link
Member Author

OK, I think this won't hurt

@h-vetinari h-vetinari merged commit b73cf6d into conda-forge:main Dec 29, 2024
9 checks passed
@h-vetinari h-vetinari deleted the rerender branch December 29, 2024 06:26
@rouault
Copy link

rouault commented Dec 29, 2024

I'm not totally sure but somehow suspect this updates to break GDAL conda-forge based builds on Mac ARM64

See https://github.com/OSGeo/gdal/actions/runs/12538381472/job/34964452787?pr=11556 which breaks with:

 dyld[24328]: Symbol not found: __ZN4absl12lts_2024072212log_internal10LogMessagelsIhLi0EEERS2_RKT_
  Referenced from: <9D909FE4-9A96-30EE-B086-0169456B43FC> /Users/runner/miniconda3/envs/test/lib/libre2.11.dylib
  Expected in:     <D623F952-8116-35EC-859D-F7F8D5DD7699> /Users/runner/miniconda3/envs/test/lib/libabsl_log_internal_message.2407.0.0.dylib
Subprocess aborted

Probably that https://github.com/conda-forge/re2-feedstock/ needs a rebuild?

@h-vetinari
Copy link
Member Author

Thanks for the report. Done in conda-forge/re2-feedstock#87

If this turns out to be more widespread, we might have to do something smarter (like a migration). For now I'm hoping these things sort themselves out.

@rouault
Copy link

rouault commented Dec 30, 2024

Thanks for the report. Done in conda-forge/re2-feedstock#87

thanks, that helped moving things a bit further. Now next candidate for rebuild is protobuf:

yld[23066]: Symbol not found: __ZN4absl12lts_2024072212log_internal10LogMessagelsIiLi0EEERS2_RKT_
  Referenced from: <7DD6F527-7A4A-3649-87B6-D68B25F8B594> /Users/runner/miniconda3/envs/test/lib/libprotobuf.28.2.0.dylib
  Expected in:     <D623F952-8116-35EC-859D-F7F8D5DD7699> /Users/runner/miniconda3/envs/test/lib/libabsl_log_internal_message.2407.0.0.dylib
Subprocess aborted

@philippjfr
Copy link

Probably the same issue but here's the same error on import of pyarrow on Mac Arm64:

https://github.com/holoviz/param/actions/runs/12548243761/job/34987161860#step:3:35

@h-vetinari
Copy link
Member Author

Argh, this is drawing wider circles than I had hoped...

@h-vetinari
Copy link
Member Author

Opened #87, let's move the discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants