grpc-cpp v1.68.2

[regro-cf-autotick-bot]

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

• Dependencies have been updated if changed: see upstream
• Tests have passed
• Updated license if changed and license_file is packaged

Information about this PR:

1. Feel free to push to the bot's branch to update this PR if needed.
2. The bot will almost always only open one PR per version.
3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name	Upstream Version	Current Version
grpc-cpp	1.68.0
protobuf	28.3

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11867415133 - please use this URL for debugging.}

[conda-forge-admin]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

• ℹ️ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

[conda-forge-admin]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

[conda-forge-admin]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

• ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
• ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13231373141. Examine the logs at this URL for more detail.}

[h-vetinari]

Thanks a lot for fixing this one! 🙏

[h-vetinari]

Pity that everything in grpc is in one CMakeLists.txt (and not just a single file/folder we can ignore/delete). This will be a conflict magnet par excellence.

[h-vetinari]

What's the pattern to identify these as "test" protos (in contrast to the one further up under test/)? The fact that it's under third_parthy?

Can you describe what the problem with them is?

[xhochy]

They are actually all only used for testing. The ones I have removed here were newly added in the 1.83 release and require the existence of various git submodules. I will try to submit an upstream patch to guard them in GRPC_BUILD_TESTS.

[h-vetinari]

Looks good, just two questions. Also we could incorporate 1.68.1 here already (just bumping version and hash should be enough)

[h-vetinari]

Something isn't working with our previous UPB_MEM_DLL_{EX,IM}PORTS setup. We already had

grpc-cpp-feedstock/recipe/patches/0008-fix-missing-DLL-exports-in-vendored-upb.patch

Lines 45 to 52 in 6ca757e

	--- a/third_party/upb/upb/mem/alloc.h
	+++ b/third_party/upb/upb/mem/alloc.h
	@@ -52,7 +52,7 @@ UPB_INLINE void upb_free(upb_alloc* alloc, void* ptr) {
	// The global allocator used by upb. Uses the standard malloc()/free().
	-extern upb_alloc upb_alloc_global;
	+UPB_MEM_DLL extern upb_alloc upb_alloc_global;

and still we're now getting

lld-link: error: undefined symbol: upb_alloc_global
>>> referenced by CMakeFiles/upb_message_lib.dir/third_party/upb/upb/message/internal/compare_unknown.c.obj:(_upb_Message_UnknownFieldsAreEqual_dont_copy_me__upb_internal_use_only)
>>> referenced by CMakeFiles/upb_message_lib.dir/third_party/upb/upb/message/internal/compare_unknown.c.obj:(upb_UnknownField_Compare)
>>> referenced by CMakeFiles/upb_message_lib.dir/third_party/upb/upb/message/internal/compare_unknown.c.obj:(upb_UnknownField_Compare)
>>> referenced 6 more time

[h-vetinari]

Looool

[964/1767] Linking CXX shared library grpc.dll
FAILED: grpc.dll grpc.lib 
C:\Windows\system32\cmd.exe /C "C:\Windows\system32\cmd.exe /C "D:\bld\grpc-split_1735631361364\_build_env\Library\bin\cmake.exe -E __create_def D:\bld\grpc-split_1735631361364\work\build-cpp\CMakeFiles\grpc.dir\.\exports.def D:\bld\grpc-split_1735631361364\work\build-cpp\CMakeFiles\grpc.dir\.\exports.def.objs && cd D:\bld\grpc-split_1735631361364\work\build-cpp" && D:\bld\grpc-split_1735631361364\_build_env\Library\bin\cmake.exe -E vs_link_dll --msvc-ver=1929 --intdir=CMakeFiles\grpc.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100261~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100261~1.0\x64\mt.exe --manifests  -- C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\HostX64\x64\link.exe /nologo @CMakeFiles\grpc.rsp  /out:grpc.dll /implib:grpc.lib /pdb:grpc.pdb /dll /version:44.1 /machine:x64 /INCREMENTAL:NO  /DEF:CMakeFiles\grpc.dir\.\exports.def && cd ."
LINK: command "C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\HostX64\x64\link.exe /nologo @CMakeFiles\grpc.rsp /out:grpc.dll /implib:grpc.lib /pdb:grpc.pdb /dll /version:44.1 /machine:x64 /INCREMENTAL:NO /DEF:CMakeFiles\grpc.dir\.\exports.def /MANIFEST:EMBED,ID=2" failed (exit code 1189) with the following output:
LINK : fatal error LNK1189: library limit of 65535 objects exceeded

[h-vetinari]

ugh, it seems it might be a format-limitation

lld-link: error: too many exported symbols (got 66065, max 65535)

Edit: yup; llvm/llvm-project@a54919e notes:

The PE/DLL format has a limit on 64k exported symbols per DLL; make sure to check this.

[h-vetinari]

It will be very painful to chase down all the required symbols (out of 65k) that are used implicitly by grpc++ etc. (much less any other grpc consumers), to the point where I'm wondering if this is a worthwhile time investment. I think I'll have to open an upstream issue for how to deal with this, maybe there's a portion of source files that we can split off into a separate library.

[mariusvniekerk]

To be fair 65k exported symbols for a library is a lot, even for something as vast as grpc.

My very rough guess is that it could be possible to split out the generated protobuf types that grpc uses into its own library and depend on that in the windows case?

[h-vetinari]

I have no idea how to slice the library into appropriate chunks, so I raised an issue upstream. Feel free to chime in there with your ideas!

[mukhery]

Would it be worth disabling the windows builds for now and then re-enabling later after an upstream fix?

[h-vetinari]

Not really. It just creates double the work whenever we then want to catch up on the windows side. Whoever wants to fix this should either open a PR here that gets the full CI matrix green, or work with upstream grpc to reactivate their shared library testing (and get the library split or the number of symbols pared down sufficiently).

[h-vetinari]

My very rough guess is that it could be possible to split out the generated protobuf types that grpc uses into its own library and depend on that in the windows case?

FWIW, I tried that, but I cannot get the __declspec(dllexport) portion to trigger correctly - for reasons that elude me. The corresponding macro is definitely set, and the file that set the declspec is included in all the translation units where the supposedly missing symbols are.