Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel + BazelToolchain + BazelDeps #3457

Merged
merged 10 commits into from
Nov 8, 2023

Conversation

franramirez688
Copy link
Contributor

@franramirez688 franramirez688 commented Nov 8, 2023

Comment on lines 38 to 42
- ``namespace``: this argument avoids collisions when you have multiple toolchain calls in the same
recipe. By setting this argument, the *conanbuild.conf* file used to pass information to the
toolchain will be named as: *<namespace>_conanbuild.conf*. The default value is ``None`` meaning that
the name of the generated file is *conanbuild.conf*. This namespace must be also set with the same
value in the constructor of ``BazelToolchain`` so that it reads the information from the proper file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a note that this argument is deprecated since the 1.62 version and will have no effect at all.

Comment on lines +95 to +91
Given the example above, and imagining that your WORKSPACE is at the same directory, you would have to add these lines in there:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads more like a tutorial than a reference for the tool... Maybe we should just enumerate the files that this generator creates, giving a general explanation of what each one of those does and then adding a section (maybe that could be just for the 2.0 docs) explaining how to use this generator or how you have to modify your project to use this generator.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I know, but I thought that Conan 1.x is not going to have that example so better to have more info like that. I agree with you, and there will be an example for Conan 2.x so this is covered, but the problem was for Conan 1.x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for @memsharded comments

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, probably leave it as-is for Conan 1.X, and improve it moving to the examples in Conan 2.0

@franramirez688 franramirez688 marked this pull request as ready for review November 8, 2023 14:51
@czoido czoido merged commit ae93358 into conan-io:develop Nov 8, 2023
@franramirez688 franramirez688 deleted the frm/bazel_integration branch November 13, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants