-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bazel][1.x][Part 1]: Bazel + BazelToolchain refactor #14958
[Bazel][1.x][Part 1]: Bazel + BazelToolchain refactor #14958
Conversation
I think there's a problem that we should resolve on how Bazel caches the artifacts and Conan packages it after the build.
|
raise ConanException("Windows and Macos needs extra BUILD configuration to be able " | ||
"to create a shared library. Please, check this reference to " | ||
"know more about it: https://bazel.build/reference/be/c-cpp") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next PR solves this issue. That one introduces changes in the template to let users create/consume shared libraries in all the platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking good, but my concerns about breaking too much, and I'd try to minimize it.
conanfile.output.warning("In bazel_layout() call, generators folder changes its default value " | ||
"from './' to './conan/' in Conan 2.x") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can make here a explicit recomendation of setting self.folders.generators_folder = "conan"
so that users can have a clue on what to do, but we can change that in the next PR
Changelog: Feature:
BazelToolchain
creates aconan_bzl.rc
file which defines theconan-config
configuration. If it exists, Bazel helper will use it automatically.Docs: conan-io/docs#3457
Closes: #14282 #14519
Next PR (BazelDeps): #14959
Overall, this PR is introducing no compatible changes, but deprecating some existing variables.
Summary:
conan_bzl.rc
file with abuild:conan-config
configuration depending on your settings/options.