Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recover xfail test for win_bash=True with msvc #15593

Merged

Conversation

memsharded
Copy link
Member

Changelog: Omit
Docs: Omit

Recover a failing test

@memsharded memsharded added this to the 2.1 milestone Feb 5, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@memsharded memsharded merged commit d4e7b3e into conan-io:develop2 Feb 5, 2024
2 checks passed
@memsharded memsharded deleted the test/restore_win_bash_test branch February 5, 2024 12:46
memsharded added a commit to memsharded/conan that referenced this pull request Feb 8, 2024
czoido pushed a commit that referenced this pull request Feb 12, 2024
* fix relativize paths in generated files

* Fix msvc profile detect test (#15552)

remove test line

Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com>

* recover xfail test for win_bash=True with msvc (#15593)

* Not skipping binaries of direct dependencies for packages being built (#15128)

* to explorer teh concept of not skipping directs

* fix

* wip

* review

* wip

---------

Co-authored-by: Juan <35701596+juansblanco@users.noreply.github.com>
Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants