Fix msvc profile detect test #15552
Merged
Fix msvc profile detect test #15552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found while asking @juansblanco to run some windows test for me - I added this back then without locally testing |
memsharded
reviewed
Jan 29, 2024
| @@ -18,7 +18,6 @@ def test_profile_detect_compiler(self): | |||
| compiler={{compiler}} | |||
| compiler.version={{detect_api.default_compiler_version(compiler, version)}} | |||
| compiler.runtime={{runtime}} | |||
| compiler.libcxx={{detect_api.detect_libcxx(compiler, version, compiler_exe)}} | |||
There was a problem hiding this comment.
Why this was not failing before in CI? I thought CI was running VS 17 already
There was a problem hiding this comment.
Investigating, curious nontheless
memsharded
pushed a commit
to memsharded/conan
that referenced
this pull request
Feb 8, 2024
remove test line Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com>
czoido
pushed a commit
that referenced
this pull request
Feb 12, 2024
* fix relativize paths in generated files * Fix msvc profile detect test (#15552) remove test line Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com> * recover xfail test for win_bash=True with msvc (#15593) * Not skipping binaries of direct dependencies for packages being built (#15128) * to explorer teh concept of not skipping directs * fix * wip * review * wip --------- Co-authored-by: Juan <35701596+juansblanco@users.noreply.github.com> Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Omit
Docs: Omit