-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpython: Fixed build error when sqlite3 wasn't used. #9891
cpython: Fixed build error when sqlite3 wasn't used. #9891
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@erikogenvik please, ask for user access on #4. The CI bot only runs approved users. |
This comment has been minimized.
This comment has been minimized.
This seems to fail on building for Clang, which ought to be unrelated to this PR. At least that's my guess from a quick look at the output. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying cpython/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
@erikogenvik Possibly related to python/cpython#82624? |
This comment has been minimized.
This comment has been minimized.
destination=self._source_subfolder, strip_root=True) | ||
|
||
@property | ||
def _with_libffi(self): | ||
# cpython 3.7.x on MSVC uses an ancient libffi 2.00-beta (which is not available at cci, and is API/ABI incompatible with current 3.2+) | ||
return self._supports_modules \ | ||
and (self.settings.compiler != "Visual Studio" or tools.Version(self._version_number_only) >= "3.8") | ||
and (not is_msvc(self) or Version(self._version_number_only) >= "3.8") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the import. And looking at the code there's a bunch h of places its needed
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 9b44f82cpython/3.8.12
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
It looks like my PR came at an inopportune time as Conan Center was in the process of moving to Conan V2, while at the same time this package experienced issues with building on MacOS. Anyone on a MacOS machine that have the ability to help? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipelineFailure in build 17 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Specify library name and version: cpython/3.10.0
If SQLite3 isn't used then the build will fail, since it tries to access the
self.options["sqlite3"]
option, which only exists if SQLite3 is enabled. This PR fixes that.fixes #9890
conan-center hook activated.