Additional patch for CPython/3.8.12, duplicate libffi symbols #13279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This comment has been minimized.
This comment has been minimized.
|
I detected other pull requests that are modifying cpython/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This was referenced Oct 3, 2022
uilianries
reviewed
Oct 3, 2022
|
@cubanpit Thank you for your contribution, do you have a log or associated issue reporting your error with more details? |
|
This is the message that pops up if I try to compile cpython/3.8.12 and shared libffi/3.4.2 without my patch: There is not issue about this opened on other projects, as far as I know. |
|
@cubanpit Could you please share your entire log, with the executed command? Also your used profile. As there is no issue opened describing your problem, it's hard to track your scenario, in case someone need to reproduce it. |
This comment has been minimized.
This comment has been minimized.
|
Here I attach the entire log from building the package with my conanfile (sorry, not very minimal, I can produce a more minimal example if needed), and then the settings and the profile files. settings.yml.txt EDIT: The log contains the "attempted build" without the patch, to show the issue. It does not fail with the patch applied. EDIT2: I also append the conaninfo of the package successfully built using the patch above. |
|
@cubanpit Thank you for providing those logs. |
|
Please open a PR upstream 🙏 |
prince-chrismc
approved these changes
Oct 6, 2022
4 tasks
jwillikers
approved these changes
Oct 11, 2022
|
@cubanpit please close the PR for 10 second then reopen it so that it retriggers a build and finally merge this change |
|
@ericLemanissier still needs to be added to access request list 😉 |
This comment has been minimized.
This comment has been minimized.
|
Failure in build 4 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
|
It seems that there is a build failure unrelated to my changes, any way to only build the specific Python version I am patching? |
|
@cubanpit I don't think is related to your PR, as your patch is only changing another version. It will need some investigation. |
|
Did we recently update the mac images? https://stackoverflow.com/questions/63972113/big-sur-clang-invalid-version-error-due-to-macosx-deployment-target |
|
@prince-chrismc I don't think so. Pinging @danimtb and @davidsanfal Just in case. |
not really... |
|
as a workaround id block that apple-clang 11 for that one version and see if that's enough add a message pointing to the comment that highlighted the failure |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had issues compiling cpython/3.8.12 on Windows with shared libffi, the linker complained about duplicated symbols.
This patch solved the problem and I later found this recent commit in the CPython repo that seems to apply the same change.