Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jfalcou-eve requirements as of v2022.03.0 #9785

Merged
merged 12 commits into from
Aug 9, 2022
Merged

Update jfalcou-eve requirements as of v2022.03.0 #9785

Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bec6584
Update EVE recipe to take care of the new clang requirement
jfalcou Mar 15, 2022
603e20f
Update g++ minimum version
jfalcou Mar 15, 2022
5340f65
Add config folder rules
jfalcou Apr 5, 2022
f4dc298
Try to deactivate Apple Clang support
jfalcou Apr 5, 2022
28a4209
Missing conandata info
jfalcou Apr 7, 2022
0019432
What about not comittign before coffee
jfalcou Apr 7, 2022
db95aed
Changes for compiler version
jfalcou Apr 19, 2022
ee79300
Update recipes/jfalcou-eve/all/conanfile.py
SSE4 Jul 1, 2022
bebb085
Remove outlier recipe cci.*
jfalcou Aug 4, 2022
52f1c37
Removed spurrious config
jfalcou Aug 4, 2022
84f68aa
Conan v2 fixes
jfalcou Aug 5, 2022
e559fd4
Fixed Version issue
jfalcou Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions recipes/jfalcou-eve/all/conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ def _min_cppstd(self):
@property
def _compilers_minimum_version(self):
return {
"gcc": "10.2",
"gcc": "11",
"Visual Studio": "16.9",
"clang": "12",
"clang": "13",
"apple-clang": "13",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new compiler requirements were working before, so now they should apply only to this new v2022.03.0 version. Is there a reason to also increase these requirements for v2021.10.0? If not, you can return different values depending on the version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. How would I go checking the actual version from within this function?

Copy link
Contributor

@jgsogo jgsogo Apr 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for example (maybe you need something custom to parse the version string):

    @property
    def _compilers_minimum_version(self):
        if tools.Version(self.version) >= "2022.03.0":  # <- not tested, given the trailing `v` I'm not sure this works out-of-the-box
                return {
                    "gcc": "11",
                    "Visual Studio": "16.9",
                    "clang": "13",
                    "apple-clang": "13",
                    }
        else:
                return {
                    "gcc": "10.2",
                    "Visual Studio": "16.9",
                    "clang": "12",
                    "apple-clang": "13",
                    }

}

Expand Down