-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jfalcou-eve requirements as of v2022.03.0 #9785
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is only required for certain versions, it should be conditioned to those versions.
This comment has been minimized.
This comment has been minimized.
Is there something I should do to fix those issues? |
it looks like some missing c++ standard feature, right?
Either apple-clang 13.0 doesn't support it, or you need to activate that standard in the build-system files |
Well, the previous recipe worked before so that's rather strange. |
or should I remove the msvc apple-clang line entirely? |
The latest PR to this recipe is 5 months old, by that time apple-clang 13 was not used here. So this is the first time this recipe tries this compiler. As this is a newer version for apple-clang I would recommend investigating the failure instead of ignoring it. Apple-clang 13 is the default in the macos world now. |
Yes maybe. For me it's the same than not working with sub-par MSVC. The library just doesn't support it. |
You are the author of the library, so you are the best one to declare if the library is supposed to work or not with those compilers. Probably the best way to go is to skip here that compiler-version and then modify the sources to support it and, with a new release of the library, enable those compiler-versions here again. |
OK. So I just remove the apple-clang entry then ? |
But still I don´t understand the purpose of this PR. The new compiler-version requirements apply to v2022.03.0 version, which is not added. You should use something a bit more complex (pseudocode): def validate(self):
if self.version in ['cci.20210823', 'v2021.10.0']:
# Check for supported compilers (the ones already in the recipe)
# Even if apple-clang should be supported (regarding C++ standard), it is isn't
if self.settings.compiler == ´apple-clang' and self.settings.compiler.version >= 13:
raise ConanInvalidConfiguration("Not supported")
if self.version in ['v2022.03.0']:
# New checks for supported compilers (the ones in this PR), which are more restritive You don't want people that was using an existing version with some compiler to start getting an error just because new versions doesn´t support that compiler. |
the thing is that it never supported apple-clang. The original recipe was not written by me and I try to make it uptodate. |
I detected other pull requests that are modifying jfalcou-eve/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Hey guys, how can I help for having this PR landed? |
We need to make it so it clearly states it doesn't compile on Apple Clang. I didn't have time to patch it. EDIT: I also missed the folders rules. Will add them |
This comment has been minimized.
This comment has been minimized.
You have added version
|
This comment has been minimized.
This comment has been minimized.
5c1f3ec
to
84f68aa
Compare
This comment has been minimized.
This comment has been minimized.
It should work, but it doesn't. It is a bug in current Conan releases, but it is not going to be backported (at least not just because of this bug) as the workaround is pretty straightforward ( Sorry for the inconvenience. |
This comment has been minimized.
This comment has been minimized.
3cebad6
to
1613bc6
Compare
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 1613bc6jfalcou-eve/v2022.03.0
|
1613bc6
to
3d9e9da
Compare
This comment has been minimized.
This comment has been minimized.
3d9e9da
to
e559fd4
Compare
Hooks produced the following warnings for commit e559fd4jfalcou-eve/v2022.03.0
jfalcou-eve/v2021.10.0
|
Please do not force push 🙏 GitHub forces us to restart the review which is not fun! |
from conans.errors import ConanInvalidConfiguration | ||
import os | ||
|
||
required_conan_version = ">=1.33.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conan v2 API need a higher version (this is not the right one but just better)
required_conan_version = ">=1.33.0" | |
required_conan_version = ">=1.43.0" |
jfalcou-eve/v2022.03.0
Latest version of EVE now requires clang 13 and g++ 11 on Linux
conan-center hook activated.