-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt6 use bundled dependencies and option to disable features. #9254
Conversation
Like the "config" option did for Qt5.
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying qt/6.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Well, using bundled dependency for which we already have a conan package is an anti-pattern, yes. On the other hand, the fix for strawberryperl and for disabled features are welcome, thanks ! |
Well it is all about reducing the complexity of the dependency tree and using "officially approved" versions to make Qt work well. For example we have our own conan server and want to make sure we can build all the packages from source where sub dependencies builds have broken on multiple occasions on different platforms. Basically using the bundled dependencies via qts buildsystem means that we don't have to make sure all the individual conanfiles are working. It is also a feature provided by Qt so it can be argued that it should also be exposed in the conanfile :) |
I would approve this pull request if you used the
conan-center-index/recipes/exiv2/all/conanfile.py Lines 64 to 67 in 06762d9
(but I cannot guarantee that other reviewer would approve it. I'm not sure we have an official policy on bundled dependencies) |
This comment has been minimized.
This comment has been minimized.
Didn't know that was possible! 👍 |
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Also cleaned up the bundled dependencies check as it was a bit fragile to have to check for bool values.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@Cyriuz don't forget:
|
Honestly, I'm not in favor to allow vendored dependencies, it's an anti-pattern and increase recipe complexity. It makes options confusing. |
Okay, well then I'll use my own fork for that. Should I remove those changes from this pr or make a new one? |
All green in build 7 (
|
Not sure if this goes against the philosophy of conan but for simplicity and for the sake of using the tested versions of qts dependencies I would like to build with the bundled dependencies instead of using libraries from conan.
I also have a bunch of features disabled which was possible to do with qt5s configure option.
conan-center hook activated.