-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt/6.x.x - Adding cross build support (only tested for Windows so far) #8116
qt/6.x.x - Adding cross build support (only tested for Windows so far) #8116
Conversation
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying qt/6.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
@@ -616,6 +616,13 @@ def _configure_cmake(self): | |||
self._cmake.definitions["FEATURE_pkg_config"] = "ON" | |||
if self.settings.compiler == "gcc" and self.settings.build_type == "Debug" and not self.options.shared: | |||
self._cmake.definitions["BUILD_WITH_PCH"]= "OFF" # disabling PCH to save disk space | |||
|
|||
if tools.cross_building(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericLemanissier
I'm in no way a qt specialist.
I remember reading to cross build qt for android, you first need a native qt.
Would the following be needed instead? + setting the correct appropriate arguments.
def build_requirements(self):
if tools.cross_building(self):
self.build_requires(f"{self.name}/{self.version}")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's the way qt 6 handles cross compilation yes, but I don't think conan allows it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean conan does not generate the required cmake modules for build requirements?
Is there missing something else?
Imho, this deserves to be added to conan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the thing is that you usually want different options for the build
qt (basically just the minimum) from the host
qt.
Edit: looks like I am wrong!
for mask in ["Find*.cmake", "*Config.cmake", "*-config.cmake"]: | ||
tools.remove_files_by_mask(self.package_folder, mask) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for m in os.listdir(os.path.join(self.package_folder, "lib", "cmake")): | ||
module = os.path.join(self.package_folder, "lib", "cmake", m, "%sMacros.cmake" % m) | ||
helper_modules = glob.glob(os.path.join(self.package_folder, "lib", "cmake", m, "QtPublic*Helpers.cmake")) | ||
if not os.path.isfile(module) and not helper_modules: | ||
tools.rmdir(os.path.join(self.package_folder, "lib", "cmake", m)) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
Failure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Specify library name and version: qt/6.x.x
qt/6.x.x - Adding cross build support (only tested for Windows so far)
conan-center hook activated.