-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qt] winextras links to dwmapi #6856
[qt] winextras links to dwmapi #6856
Conversation
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying qt/5.x.x recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
recipes/qt/5.x.x/conanfile.py
Outdated
if self.options.qtwinextras: | ||
_create_module("WinExtras") | ||
self.cpp_info.components["qtWinExtras"].system_libs.append("dwmapi") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is qtwinextras
a valid option on non-Windows systems?
As far as I can see, it's not removed in config_options
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's not a valid option for non windows platforms, [see here] (https://doc.qt.io/qt-5/qtwinextras-index.html)
This comment has been minimized.
This comment has been minimized.
I just realized, default for qt package on Windows is static linkage (which is weird by itself, since default - in order to comply with LGPL - should be shared). So appending to the system libs needs to be in the section that checks for static linkage (starting line 1084) |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Please ask for access in #4. |
This comment has been minimized.
This comment has been minimized.
@uilianries how can I see what went wrong? |
unfortunately, with unexpected error there is no way to see log on what exactly have happened. for this particular failure, it was an upload error:
perhaps, network issue |
All green in build 6 (
|
Specify library name and version: qt/5.15.2
There were linker issues using QT Winextras component that is solved by this PR
Fixes #6855
conan-center hook activated.