Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qt] winextras links to dwmapi #6856

Merged

Conversation

KerstinKeller
Copy link
Contributor

@KerstinKeller KerstinKeller commented Aug 14, 2021

Specify library name and version: qt/5.15.2

There were linker issues using QT Winextras component that is solved by this PR
Fixes #6855


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2021

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Aug 14, 2021

I detected other pull requests that are modifying qt/5.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Aug 14, 2021
4 tasks
Comment on lines 1078 to 1080
if self.options.qtwinextras:
_create_module("WinExtras")
self.cpp_info.components["qtWinExtras"].system_libs.append("dwmapi")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is qtwinextras a valid option on non-Windows systems?
As far as I can see, it's not removed in config_options.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not a valid option for non windows platforms, [see here] (https://doc.qt.io/qt-5/qtwinextras-index.html)

@SSE4 SSE4 changed the title winextras links to dwmapi [qt] winextras links to dwmapi Aug 16, 2021
@conan-center-bot

This comment has been minimized.

@KerstinKeller
Copy link
Contributor Author

I just realized, default for qt package on Windows is static linkage (which is weird by itself, since default - in order to comply with LGPL - should be shared). So appending to the system libs needs to be in the section that checks for static linkage (starting line 1084)

@conan-center-bot

This comment has been minimized.

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
@conan-center-bot

This comment has been minimized.

@madebr
Copy link
Contributor

madebr commented Aug 16, 2021

Please ask for access in #4.
Also, can you please add Fixes #6855 to your initial message? Then github will automatically close your issue.

@conan-center-bot

This comment has been minimized.

@KerstinKeller
Copy link
Contributor Author

@uilianries how can I see what went wrong?

@SSE4 SSE4 closed this Aug 29, 2021
@SSE4
Copy link
Contributor

SSE4 commented Aug 29, 2021

@uilianries how can I see what went wrong?

unfortunately, with unexpected error there is no way to see log on what exactly have happened.
we're (slowly) improving the CI to turn some unexpected errors into correct (human-readable, user-friendly) error messages.

for this particular failure, it was an upload error:

Error running command `conan upload qt/5.15.2@#1e902b0406eaf5f9df71074a080224a4:3f6053cb7e2ae8a9639326c5df78e53b54511aae -r c3i_PR-6856`

perhaps, network issue

@SSE4 SSE4 reopened this Aug 29, 2021
@conan-center-bot
Copy link
Collaborator

All green in build 6 (861d4d7261d6da5cfd899fca0407230f82f253eb):

  • qt/5.15.2@:
    All packages built successfully! (All logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] qt/5.15.2: qt5 winextras needs to link dwmapi.lib
7 participants