Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct usage of with_vulkan flag in qt/5.15.2 #6781

Merged
merged 4 commits into from
Sep 2, 2021

Conversation

AndreyMlashkin
Copy link
Contributor

@AndreyMlashkin AndreyMlashkin commented Aug 9, 2021

Specify library name and version: qt/5.15.2

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

fixes #6773

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

/cc @ericLemanissier

@AndreyMlashkin AndreyMlashkin changed the title correct usage of with_vulkan flag correct usage of with_vulkan flag in qt/5.15.2 Aug 10, 2021
@AndreyMlashkin
Copy link
Contributor Author

It works just fine for me on Linux and Windows, but I've got an error on Mac:

-f libqsqlite.dylib /Users/rr-admin/.conan/data/qt/5.15.2/andrei/test/build/25d4c97d065f7fc9413fa65c77ac475e8bf34585/build_folder/qtbase/plugins/sqldrivers/libqsqlite.dylib
compiling /Users/rr-admin/.conan/data/qt/5.15.2/andrei/test/source/qt5/qtbase/src/plugins/platforms/cocoa/qcocoanativeinterface.mm
compiling /Users/rr-admin/.conan/data/qt/5.15.2/andrei/test/source/qt5/qtbase/src/plugins/platforms/cocoa/qcocoaeventdispatcher.mm
In file included from /Users/rr-admin/.conan/data/qt/5.15.2/andrei/test/source/qt5/qtbase/src/plugins/platforms/cocoa/qcocoawindowmanager.mm:41In file included from /Users/rr-admin/.conan/data/qt/5.15.2/andrei/test/source/qt5/qtbase/src/plugins/platforms/cocoa/qnsview.mm:43:
/Users/rr-admin/.conan/data/qt/5.15.2/andrei/test/source/qt5/qtbase/src/plugins/platforms/cocoa/qcocoawindow.h:56:10: fatal error: 'MoltenVK/mvk_vulkan.h' file not found
#include <MoltenVK/mvk_vulkan.h>
^~~~~~~~~~~~~~~~~~~~~~~
:
/Users/rr-admin/.conan/data/qt/5.15.2/andrei/test/source/qt5/qtbase/src/plugins/platforms/cocoa/qcocoawindow.h:56:10: fatal error: 'MoltenVK/mvk_vulkan.h' file not found
#include <MoltenVK/mvk_vulkan.h>
^~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[5]: *** [.obj/qcocoawindowmanager.o] Error 1
make[5]: *** Waiting for unfinished jobs....
In file included from /Users/rr-admin/.conan/data/qt/5.15.2/andrei/test/source/qt5/qtbase/src/plugins/platforms/cocoa/qnswindow.mm:43:
/Users/rr-admin/.conan/data/qt/5.15.2/andrei/test/source/qt5/qtbase/src/plugins/platforms/cocoa/qcocoawindow.h:56:10: fatal error: 'MoltenVK/mvk_vulkan.h' file not found
#include <MoltenVK/mvk_vulkan.h>
^~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[5]: *** [.obj/qnswindow.o] Error 1
In file included from /Users/rr-admin/.conan/data/qt/5.15.2/andrei/test/source/qt5/qtbase/src/plugins/platforms/cocoa/qcocoanativeinterface.mm:41:
/Users/rr-admin/.conan/data/qt/5.15.2/andrei/test/source/qt5/qtbase/src/plugins/platforms/cocoa/qcocoawindow.h:56:10: fatal error: 'MoltenVK/mvk_vulkan.h' file not found
#include <MoltenVK/mvk_vulkan.h>
^~~~~~~~~~~~~~~~~~~~~~~
In file included from /Users/rr-admin/.conan/data/qt/5.15.2/andrei/test/source/qt5/qtbase/src/plugins/platforms/cocoa/qnswindowdelegate.mm:42:
/Users/rr-admin/.conan/data/qt/5.15.2/andrei/test/source/qt5/qtbase/src/plugins/platforms/cocoa/qcocoawindow.h:56:10: fatal error: 'MoltenVK/mvk_vulkan.h' file not found
#include <MoltenVK/mvk_vulkan.h>
^~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

What should I add?
I don't see, that qt6 recipe add MoltenVK

@conan-center-bot

This comment has been minimized.

recipes/qt/5.x.x/conanfile.py Outdated Show resolved Hide resolved
recipes/qt/5.x.x/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Aug 14, 2021

I detected other pull requests that are modifying qt/5.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ericLemanissier
Copy link
Contributor

can you please add fixes conan-io/conan-center-index#6773 in the PR description ?

@conan-center-bot conan-center-bot requested a review from SSE4 August 17, 2021 12:00
@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor Author

in the end, it will be a backport of #6835

Copy link
Contributor

@ericLemanissier ericLemanissier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the moltenvk thing needed here too ?

recipes/qt/5.x.x/conanfile.py Outdated Show resolved Hide resolved
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
@AndreyMlashkin
Copy link
Contributor Author

Yes, exactly :)

@conan-center-bot

This comment has been minimized.

prince-chrismc
prince-chrismc previously approved these changes Aug 31, 2021
@ghost ghost mentioned this pull request Aug 31, 2021
4 tasks
@conan-center-bot
Copy link
Collaborator

All green in build 6 (7118282756c375973d7367bee771b941ad75200f):

  • qt/5.15.2@:
    All packages built successfully! (All logs)

@ghost ghost mentioned this pull request Sep 2, 2021
4 tasks
@conan-center-bot conan-center-bot merged commit a997726 into conan-io:master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] qt/5.15.2: can't build with vulkan support
6 participants