Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imake: add imake/1.0.8 recipe #6677

Merged
merged 6 commits into from
Aug 6, 2021
Merged

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Aug 4, 2021

Specify library name and version: imake/1.0.8

For #6387

dependency tree: sdl -> nas -> imake -> xorg-proto -> xorg-macros


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@madebr
Copy link
Contributor Author

madebr commented Aug 4, 2021

@jgsogo
Can you (manually) start a job to create armv8 macos packages for xorg-proto?
xorg-proto was merged today. So it feels strange to open a pr on the same day to trigger creation of new packages.

@jgsogo
Copy link
Contributor

jgsogo commented Aug 5, 2021

@jgsogo
Copy link
Contributor

jgsogo commented Aug 5, 2021

we are on it: #6686

@conan-center-bot

This comment has been minimized.

@madebr
Copy link
Contributor Author

madebr commented Aug 5, 2021

This is probably because I added test_type = "build_requires" to the test package's recipe.

recipes/imake/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/imake/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/imake/all/test_package/conanfile.py Outdated Show resolved Hide resolved
@madebr
Copy link
Contributor Author

madebr commented Aug 5, 2021

@jgsogo
The error #6677 (comment) shows that there is a possible bootstrap problem on c3i when cross building.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@madebr
Copy link
Contributor Author

madebr commented Aug 5, 2021

@jgsogo
Weird.
The log contains:

    imake/1.0.8:c58972ce7fa79168bcca07b3885d2a61402d8743 - Download

Where it should be

    imake/1.0.8:c58972ce7fa79168bcca07b3885d2a61402d8743 - Build

See #6677 (comment)

@jgsogo
Copy link
Contributor

jgsogo commented Aug 5, 2021

If you have a look at the output table, you can see it says UPSTREAM + TEST_FAILED for this configuration: the package is already available in the repository created for this pull-request (it was already built, latest commit is just modifying test_package), and we are just running conan test in the CI, so the package needs to be downloaded and the error comes from the conan test output, not from conan install --build.

The table is useful to know where the error comes from:

image

...although I agree the error message in GitHub should provide that information as well. Maybe we can just add the first lines of the log output with the command to the snippet we are showing in Github:

conan test conan-center-index/recipes/imake/all/test_package/conanfile.py imake/1.0.8@ --profile:host=/Users/jenkins/w/BuildSingleReference/27646/2fdb7b99-e353-499d-aa2f-153a73d71019/profile_host.txt --profile:build=default

[...]
Downloading conan_export.tgz
xorg-proto/2021.4: Downloaded recipe revision a33437da70591bb16417a77169e3f145
xorg-macros/
...

@jgsogo
Copy link
Contributor

jgsogo commented Aug 5, 2021

Now the actual issue, why package imake/1.0.8:c58972ce7fa79168bcca07b3885d2a61402d8743 is not found. Probably (this is just a guess) it was being uploaded when the new commit arrived and the previous job was cancelled. Sometimes the cancel request stops gracefully, sometimes it kills the job... if it was uploading the package the upload might be incomplete (some Conan files missing) and Conan thinks the package exists (IIRC it checks conaninfo.txt) but at the time it is going to download it, not all the files are available.

Why it doesn't happen more often? Because typically, when someone pushes changes to a PR and the previous job is cancelled, the changes affect the recipe-revision and it doesn't matter if one of the packages is corrupted.

I'll check in Artifactory and (probably) trigger again this PR

@madebr
Copy link
Contributor Author

madebr commented Aug 5, 2021

Thanks.
c3i learning new things always surprises me 😄
Great teacher you are :yoda: 🤣 😉

@jgsogo
Copy link
Contributor

jgsogo commented Aug 5, 2021

Thanks.
c3i learning new things always surprises me 😄
Great teacher you are :yoda: 🤣 😉

Thanks! 😊 C3i has some secrets behind the scenes... sometimes it is useful also for me to try to explain the issue, and usually, I mention @danimtb, @uilianries and @SSE4 in case it is something that helps them to improve their understanding of the system (not all of us know about every detail).


Indeed, that package-ID is corrupted in Artifactory, it is missing conanmanifest.txt file:

image

To fix it, we can just remove the package from that repository, or whatever forces Conan to build again the package and upload it. From the user's perspective, all you can do is force a new recipe revision (or a different PR number).


PS.- There is a feature requested to the Artifactory team to enforce consistency of packages, making the uploads transactional, or returning that a package doesn't exist if it is not valid.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@madebr
Copy link
Contributor Author

madebr commented Aug 5, 2021

@madebr madebr closed this Aug 5, 2021
@madebr madebr reopened this Aug 5, 2021
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@madebr
Copy link
Contributor Author

madebr commented Aug 5, 2021

c3i go brrrrrrrrr

@madebr madebr closed this Aug 5, 2021
@madebr madebr reopened this Aug 5, 2021
@conan-center-bot
Copy link
Collaborator

All green in build 12 (b7aaf7f18b60f735a154cfd19e8eeedb3998da0d):

  • imake/1.0.8@:
    All packages built successfully! (All logs)

Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step by step 💪

@SSE4 SSE4 requested a review from uilianries August 6, 2021 07:20
Copy link
Contributor

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paso a paso!

@madebr
Copy link
Contributor Author

madebr commented Aug 6, 2021

stap per stap

@conan-center-bot conan-center-bot requested a review from czoido August 6, 2021 11:58
@conan-center-bot conan-center-bot merged commit d8c8cf6 into conan-io:master Aug 6, 2021
@madebr madebr deleted the imake_recipe branch August 6, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants