Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nas] Network audio system #6388

Merged
merged 16 commits into from
Aug 17, 2021
Merged

[nas] Network audio system #6388

merged 16 commits into from
Aug 17, 2021

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Jul 17, 2021

Specify library name and version: nas

@jgsogo jgsogo mentioned this pull request Jul 17, 2021
Merged
2 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@jgsogo
Copy link
Contributor Author

jgsogo commented Jul 17, 2021

Shall we add xutils-dev to xorg/system and then use it as a build-requires as well?

@jgsogo @madebr
Update recipes/nas/all/conandata.yml
e6f730d 
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
@madebr madebr mentioned this pull request Aug 4, 2021
Merged
4 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@madebr
Copy link
Contributor

madebr commented Aug 6, 2021 •
edited
Loading

Looks like our imake recipe is missing a lot of files:
https://rpmfind.net/linux/RPM/fedora/devel/rawhide/x86_64/i/imake-1.0.8-7.fc35.x86_64.html
(files in /usr/share/X11/config)

Found them: https://gitlab.freedesktop.org/xorg/util/cf

@madebr
Copy link
Contributor

madebr commented Aug 6, 2021

Adding xorg-cf-files, it also needs gccmakedepend.
https://gitlab.freedesktop.org/xorg/util/gccmakedep

@madebr
Copy link
Contributor

madebr commented Aug 7, 2021 •
edited
Loading

See jgsogo#8
Depends on:

@madebr
Copy link
Contributor

madebr commented Aug 13, 2021

@jgsogo
Can you trigger this build again please?

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@madebr
Copy link
Contributor

madebr commented Aug 16, 2021

See jgsogo#8

It used to work, right now I have an issue with xorg/system so I could not test it.

@conan-center-bot

This comment has been minimized.

Sign in to view
@madebr
Copy link
Contributor

madebr commented Aug 16, 2021

I hope this is the one and only recipe making use of imake.

See jgsogo#9

madebr and others added 2 commits August 16, 2021 17:56
@madebr
nas: working once again (#9)
83591cc
@jgsogo @madebr
Apply suggestions from code review
338305b 
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
@jgsogo
Copy link
Contributor Author

jgsogo commented Aug 16, 2021

@madebr, you deserve all the credit for this PR 👏

@conan-center-bot
Copy link
Collaborator

All green in build 14 (338305b3c1b3ec04286d1ed077c859c4605dba52):

  • nas/1.9.4@:
    All packages built successfully! (All logs)

madebr
madebr approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@madebr madebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super pr! Clearly written by a genius!

🤣 😉

@github-actions github-actions bot mentioned this pull request Aug 16, 2021
Open
@jgsogo
Copy link
Contributor Author

jgsogo commented Aug 17, 2021

...it all started when a naïve guy tried to add magnum recipe and the dependency chain exploded 😅 .

Next steps:

@jgsogo jgsogo requested a review from SSE4 August 17, 2021 08:49
SSE4
SSE4 approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR is a masterpiece, the best recipe I've seen in CCI so far

@SSE4 SSE4 requested a review from uilianries August 17, 2021 08:51
@conan-center-bot conan-center-bot merged commit a7c3c0c into conan-io:master Aug 17, 2021
@jgsogo jgsogo deleted the add/nas branch August 17, 2021 15:22
@jgsogo jgsogo mentioned this pull request Aug 20, 2021
Closed
18 tasks
@jgsogo jgsogo mentioned this pull request Aug 28, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@madebr madebr madebr approved these changes

@SSE4 SSE4 SSE4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgsogo @conan-center-bot @madebr @SSE4 @uilianries