Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abseil: inject CMAKE_SYSTEM_PROCESSOR if cross-building #6609

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jul 31, 2021

Specify library name and version: lib/1.0

When you cross-compile abseil, you can see this warning:

CMake Warning at source_subfolder/absl/copts/AbseilConfigureCopts.cmake:30 (message):
  Value of CMAKE_SYSTEM_PROCESSOR () is unknown and cannot be used to set
  ABSL_RANDOM_RANDEN_COPTS
Call Stack (most recent call first):
  source_subfolder/CMake/AbseilHelpers.cmake:18 (include)
  source_subfolder/CMakeLists.txt:73 (include)

Indeed, abseil has some logic based on CMAKE_SYSTEM_PROCESSOR: https://github.com/abseil/abseil-cpp/blob/20210324.2/absl/copts/AbseilConfigureCopts.cmake#L15-L32
When you cross-compile, CMAKE_SYSTEM_PROCESSOR is empty by default (and conan doesn't set this variable for you).

self.settings.arch should be sufficient.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@ghost
Copy link

ghost commented Jul 31, 2021

I detected other pull requests that are modifying abseil/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Collaborator

All green in build 1 (4fe8a0db8db45d3180fbe1c34f3e40ece1c23e02):

  • abseil/20200205@:
    All packages built successfully! (All logs)

  • abseil/20200923.1@:
    All packages built successfully! (All logs)

  • abseil/20200225.2@:
    All packages built successfully! (All logs)

  • abseil/20200225.3@:
    All packages built successfully! (All logs)

  • abseil/20200923@:
    All packages built successfully! (All logs)

  • abseil/20210324.0@:
    All packages built successfully! (All logs)

  • abseil/20210324.2@:
    All packages built successfully! (All logs)

  • abseil/20200923.2@:
    All packages built successfully! (All logs)

  • abseil/20200923.3@:
    All packages built successfully! (All logs)

  • abseil/20210324.1@:
    All packages built successfully! (All logs)

@SSE4 SSE4 requested a review from uilianries August 1, 2021 12:28
@conan-center-bot conan-center-bot merged commit 0cde6a3 into conan-io:master Aug 3, 2021
@SpaceIm SpaceIm deleted the fix/abseil-copts branch August 3, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants