Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abseil: add shared option + fix link to libm + drop few patch versions + modernize #6383

Merged
merged 15 commits into from
Jan 24, 2022
Merged

abseil: add shared option + fix link to libm + drop few patch versions + modernize #6383

merged 15 commits into from
Jan 24, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jul 17, 2021

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@SpaceIm SpaceIm mentioned this pull request Jul 17, 2021
Closed
@SpaceIm SpaceIm force-pushed the feature/abseil-shared branch from a45afb6 to 2f070cb Compare July 17, 2021 09:02
@ghost ghost mentioned this pull request Jul 17, 2021
Closed
@ghost
Copy link

ghost commented Jul 17, 2021 •
edited by ghost
Loading

I detected other pull requests that are modifying abseil/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Jul 17, 2021
Merged
4 tasks
@github-actions github-actions bot mentioned this pull request Jul 17, 2021
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jul 17, 2021 •
edited
Loading

Ok, two issues to fix:

  • shared was not supported before 20200225. And 20200205 is a CCI version actually.
  • On Windows, there is an additional component for the dll

@SpaceIm SpaceIm force-pushed the feature/abseil-shared branch from f159adc to d5a563e Compare July 17, 2021 10:54
@SpaceIm SpaceIm force-pushed the feature/abseil-shared branch from d5a563e to e90f361 Compare July 17, 2021 10:57
@conan-center-bot

This comment has been minimized.

Sign in to view
@ghost ghost mentioned this pull request Jul 31, 2021
Merged
4 tasks
@stale
Copy link

stale bot commented Aug 30, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 30, 2021
@ghost ghost mentioned this pull request Sep 23, 2021
Closed
4 tasks
@SSE4
Copy link
Contributor

SSE4 commented Sep 27, 2021

are we missing status component?
https://chromium.googlesource.com/chromium/src.git/+/refs/heads/main/third_party/abseil-cpp/absl/status/CMakeLists.txt

also there are conflicts, please rebase

@stale stale bot removed the stale label Sep 27, 2021
This was referenced Sep 27, 2021
Merged
Merged
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm mentioned this pull request Jan 23, 2022
Merged
4 tasks
@SpaceIm SpaceIm changed the title abseil: add shared option abseil: add shared option + fix link to libm + drop few patch versions + modernize Jan 23, 2022
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm closed this Jan 23, 2022
@SpaceIm SpaceIm reopened this Jan 24, 2022
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm force-pushed the feature/abseil-shared branch from d46ea11 to ef7d64b Compare January 24, 2022 10:05
@SpaceIm
ensure C++ standard consistency
f336e83 
revert conan-io#7443

it's almost impossible to predict if those headers are available. abseil has a mechanism to detect these headers, trust it. Since we are trying very hard to inject at build time the default C++ standard of the compiler or the one given in profile, it should be fine.
@SpaceIm SpaceIm force-pushed the feature/abseil-shared branch from ef7d64b to f336e83 Compare January 24, 2022 10:07
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 24, 2022 •
edited
Loading

The complete fix for ABI consistency of abseil which should come in addition to f336e83 is explained in #7443 (comment)

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 24, 2022 •
edited
Loading

@madebr @SSE4 @uilianries @ericLemanissier @prince-chrismc @toge could you review this PR please? The fix for libm is required to enable shared in grpc (#9044 (comment)).

@conan-center-bot
Copy link
Collaborator

All green in build 15 (f336e83cdf870bf1563cd5cd4c14afa10878e2c0):

  • abseil/20210324.2@:
    All packages built successfully! (All logs)

  • abseil/20211102.0@:
    All packages built successfully! (All logs)

  • abseil/20200923.3@:
    All packages built successfully! (All logs)

  • abseil/20200225.3@:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit caf4faa into conan-io:master Jan 24, 2022
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 24, 2022 •
edited
Loading

Thanks, I'll try to submit a PR to improve API & ABI compatibility between abseil and downstream recipes. Basically it should be freezed at CMake configuration time of abseil (but not hardcoded in conan recipe because it's too fragile), but we must rely on its internal mechanism.

@SpaceIm SpaceIm deleted the feature/abseil-shared branch January 24, 2022 16:09
Sahnvour pushed a commit to Sahnvour/conan-center-index that referenced this pull request Jan 30, 2022
@SpaceIm @Sahnvour
(conan-io#6383) abseil: add shared option + fix link to libm + drop f…
8740c70 
…ew patch versions + modernize

* add shared option

* system libs for FreeBSD and iOS/tvOS/watchOS

* move checks to validate()

* stop maintenance of unofficial version 20200205

* fix abseil_dll component for windows shared build

* stop maintenance of unofficial version 20200205

* finer grained export of patches

* drop 20200205 in config.yml as well

* modernize

* absl-string may link to libm

* drop maintenance of several patch versions

keep last patch of each "major" version

* drop shared with msvc for the moment

* ensure C++ standard consistency

revert conan-io#7443

it's almost impossible to predict if those headers are available. abseil has a mechanism to detect these headers, trust it. Since we are trying very hard to inject at build time the default C++ standard of the compiler or the one given in profile, it should be fine.
@Ahajha Ahajha mentioned this pull request Mar 12, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@SSE4 SSE4 SSE4 approved these changes

@toge toge toge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SpaceIm @conan-center-bot @SSE4 @FMeinicke @toge @uilianries