-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignition-transport #3274
Add ignition-transport #3274
Conversation
Depends on: |
Failure in build 1 (
|
self.cpp_info.names["cmake_find_package"] = "ignition-transport{}".format(version_major) | ||
self.cpp_info.names["cmake_find_package_multi"] = "ignition-transport{}".format(version_major) | ||
|
||
# FIXME: create in file ignition-transport6-all-config.cmake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you manually checked the generated -config.cmake
files?
If there is only one file created, then this FIXME can be removed.
self.cpp_info.names["cmake_find_package_multi"] = "ignition-transport{}".format(version_major) | ||
|
||
# FIXME: create in file ignition-transport6-all-config.cmake | ||
self.cpp_info.components["libignition-transport-all"].libs = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? No libs would mean that this package is header-only.
|
||
# FIXME: create in file ignition-transport6-all-config.cmake | ||
self.cpp_info.components["libignition-transport-all"].libs = [] | ||
self.cpp_info.components["libignition-transport-all"].requires = ["libignition-transport-eigen3"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These requires do not exist.
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Failure in build 3 (
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Specify library name and version: ignition-transport/9.0.0
conan-center hook activated.