Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignition-transport #3274

Closed
wants to merge 4 commits into from
Closed

Conversation

joxoby
Copy link
Contributor

@joxoby joxoby commented Oct 20, 2020

Specify library name and version: ignition-transport/9.0.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@joxoby
Copy link
Contributor Author

joxoby commented Oct 20, 2020

Depends on:
ignition-cmake
ignition-msgs
protobuf

@conan-center-bot
Copy link
Collaborator

Failure in build 1 (5d736fa2aca3dfc547426346601a60acb3983e95):

  • Error processing recipe (ref 'ignition-transport/9.0.0'): Linux x86_64, Release, gcc 7, libstdc++11 . Options: ignition-transport:shared-False
    You are depending on 'protobuf/3.12.3' but it is not in the repository

self.cpp_info.names["cmake_find_package"] = "ignition-transport{}".format(version_major)
self.cpp_info.names["cmake_find_package_multi"] = "ignition-transport{}".format(version_major)

# FIXME: create in file ignition-transport6-all-config.cmake
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you manually checked the generated -config.cmake files?
If there is only one file created, then this FIXME can be removed.

self.cpp_info.names["cmake_find_package_multi"] = "ignition-transport{}".format(version_major)

# FIXME: create in file ignition-transport6-all-config.cmake
self.cpp_info.components["libignition-transport-all"].libs = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? No libs would mean that this package is header-only.


# FIXME: create in file ignition-transport6-all-config.cmake
self.cpp_info.components["libignition-transport-all"].libs = []
self.cpp_info.components["libignition-transport-all"].requires = ["libignition-transport-eigen3"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These requires do not exist.

joxoby and others added 3 commits October 20, 2020 08:25
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
@conan-center-bot
Copy link
Collaborator

Failure in build 3 (b8c0a1e285d4105b757787dac10d280c91707603):

  • Error processing recipe (ref 'ignition-transport/9.0.0'): Linux x86_64, Release, gcc 7, libstdc++11 . Options: ignition-transport:shared-False
    You are depending on 'protobuf/3.12.3' but it is not in the repository

@stale
Copy link

stale bot commented Dec 1, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 1, 2020
@stale
Copy link

stale bot commented Dec 31, 2020

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants