-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignition-msgs #3273
Add ignition-msgs #3273
Conversation
Failure in build 1 (
|
Depends on: |
self.cpp_info.names["cmake_find_package"] = "ignition-msgs{}".format(version_major) | ||
self.cpp_info.names["cmake_find_package_multi"] = "ignition-msgs{}".format(version_major) | ||
|
||
# FIXME: create in file ignition-msgs6-all-config.cmake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you manually checked that ignition-msgs creates only one -config.cmake
file?
If so, then this FIXME can be removed, as the problem with ignition-math
is that it needs to generate multiple -config.cmake
files (which conan cannot do yet).
self.cpp_info.names["cmake_find_package_multi"] = "ignition-msgs{}".format(version_major) | ||
|
||
# FIXME: create in file ignition-msgs6-all-config.cmake | ||
self.cpp_info.components["libignition-msgs-all"].libs = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? No libs means that this package is header-only.
|
||
# FIXME: create in file ignition-msgs6-all-config.cmake | ||
self.cpp_info.components["libignition-msgs-all"].libs = [] | ||
self.cpp_info.components["libignition-msgs-all"].requires = ["libignition-msgs-eigen3"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should contain the conan component names on which this component (=libignition-msgs-all
) depends.
In this case these are: ["tinyxml2::tinyxml2", "protobuf::protobuf", "ignition-math::ignition-math"]
.
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Failure in build 4 (
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Specify library name and version: ignition-msgs/6.0.0
conan-center hook activated.