Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignition-msgs #3273

Closed
wants to merge 5 commits into from
Closed

Add ignition-msgs #3273

wants to merge 5 commits into from

Conversation

joxoby
Copy link
Contributor

@joxoby joxoby commented Oct 20, 2020

Specify library name and version: ignition-msgs/6.0.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

Failure in build 1 (7344eca72ab6ea468667f5a07aadc7886454bd1a):

  • Error processing recipe (ref 'ignition-msgs/6.0.0'): Linux x86_64, Release, gcc 7, libstdc++11 . Options: ignition-msgs:shared-False
    You are depending on 'protobuf/3.12.3' but it is not in the repository

@joxoby
Copy link
Contributor Author

joxoby commented Oct 20, 2020

Depends on:
protobuf
ignition-cmake
ignition-math

@joxoby joxoby mentioned this pull request Oct 20, 2020
4 tasks
self.cpp_info.names["cmake_find_package"] = "ignition-msgs{}".format(version_major)
self.cpp_info.names["cmake_find_package_multi"] = "ignition-msgs{}".format(version_major)

# FIXME: create in file ignition-msgs6-all-config.cmake
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you manually checked that ignition-msgs creates only one -config.cmake file?
If so, then this FIXME can be removed, as the problem with ignition-math is that it needs to generate multiple -config.cmake files (which conan cannot do yet).

self.cpp_info.names["cmake_find_package_multi"] = "ignition-msgs{}".format(version_major)

# FIXME: create in file ignition-msgs6-all-config.cmake
self.cpp_info.components["libignition-msgs-all"].libs = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? No libs means that this package is header-only.


# FIXME: create in file ignition-msgs6-all-config.cmake
self.cpp_info.components["libignition-msgs-all"].libs = []
self.cpp_info.components["libignition-msgs-all"].requires = ["libignition-msgs-eigen3"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should contain the conan component names on which this component (=libignition-msgs-all) depends.
In this case these are: ["tinyxml2::tinyxml2", "protobuf::protobuf", "ignition-math::ignition-math"].

joxoby and others added 3 commits October 20, 2020 08:24
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
@conan-center-bot
Copy link
Collaborator

Failure in build 4 (74064353c976b509444b512f11d19620c3f85bfc):

  • Error processing recipe (ref 'ignition-msgs/6.0.0'): Linux x86_64, Release, gcc 7, libstdc++11 . Options: ignition-msgs:shared-False
    You are depending on 'protobuf/3.12.3' but it is not in the repository

@stale
Copy link

stale bot commented Dec 1, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 1, 2020
@stale
Copy link

stale bot commented Dec 31, 2020

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants