-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt: fix minor issues in 6.x #20932
qt: fix minor issues in 6.x #20932
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'. 👋 @ericLemanissier @jwillikers @MartinDelille you might be interested. 😉 |
I detected other pull requests that are modifying qt/6.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
To best of my knowledge, this PR is not in conflict with the one above. |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 54d709fqt/6.5.3@#35b5e875564ea94592eb5539a11525b1
qt/6.5.0@#5a55ef2c480c54a3d40e2b72f0a83db9
qt/6.4.2@#11b014da380b3788d9752fc268c00e32
qt/6.3.2@#26a72706742bdb3b73fa671c003544aa
qt/6.5.1@#aeaa16f1dff4d586f43f312a01cdf610
qt/6.6.0@#31422cf77ba3fed4b18efdbfac490dca
qt/6.5.2@#194a7c1bcee19f0b9351f3f08f4387d5
|
There are two reviewers, what else is missing? |
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cf https://github.com/conan-io/conan-center-index/blob/master/docs/review_process.md#rule-of-2-reviews
You just have to wait for a review from a team member: team
type in https://github.com/conan-io/conan-center-index/blob/master/.c3i/reviewers.yml
Thanks for clarifying the reviewers process. I was misled by these two sentences: "At least 2 approving reviews are required by reviewers with write access" and "Merging can be done automatically with 2 approving reviews." I assume these are generic GitHub messages. |
Specify library name and version: qt/6.5.3
Fix issue #20924.
Note to reviewers:
Tested with
Pragmas are needed without patch
I'm using Conan 2.0, hooks don't work as per documentation.