-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt/5.15.11: Expose QSvgPlugin and QSvgIconPlugin #20817
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'. 👋 @ericLemanissier @jwillikers @MartinDelille you might be interested. 😉 |
e5703e1
to
90f16c9
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Regarding conflicting PR for qt/5.x.x Should not be an issue to the best of my knowledge:
I believe this one will require manual merging. Since #18650 has been siting on ice for a while, what would be the proper procedure to keep things going? |
90f16c9
to
869f10f
Compare
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 869f10fqt/5.15.11@#64fc18b0c5ab189f347993a9853144ad
qt/5.15.7@#956834e91ca0b97415a8110efb8b66b1
qt/5.15.9@#de05718f5087c2333a2ffe7a0d8df428
qt/5.15.10@#59d205b1b34bbef121caaee9541cc588
qt/5.15.8@#189b520c8a2aeb890245f049a9e415b8
|
869f10f
to
680877f
Compare
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 4 ( |
fixes #20816
Specify library name and version: qt/5.15.11
I wrote a little proof of concept here:
https://github.com/fnadeau/qt-demo.git
A simple app that display 4 buttons with icons. Two use SVG and two use PNG as image source.
When build with
qt/5.15.11
in conanfile.txt, this is the resultIf locally building this PR with something like:
and changing
qt/5.15.11
toqt/5.15.11@fnadeau/github
in conanfile.txt, you'll get thisI'm using conan 2.0, not yet supported as per documentation, but I did try at least one configuration.