Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libmagic: add new recipe #19508
libmagic: add new recipe #19508
Changes from 12 commits
09db67d
2bdb6c9
58c597d
8338194
1af8583
b855579
68c3d27
d03666a
0302ac7
b10f341
57f2e7e
5e75168
b7bc80e
5c87270
21c3073
6924bc8
f7b6095
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm inclined to think that the
DocumenRef-
portion should indicate the library or project name instead of the specific file, i.e.DocumentRef-file
instead ofDocumentRef-COPYING
. This fits better with the example in D.3 Simple license expressions. I'm not sure, but I kind of get that feeling this is supposed to be a reference to an SPDX document that we create, i.e. like the SPDXJSONExample-v2.2.spdx.json, but I don't think anyone has done something like that on CCI.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RubenRBS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked it time ago: https://opensource.stackexchange.com/a/14309/31147