-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libmagic: add new recipe #19508
libmagic: add new recipe #19508
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit a7f9f62libmagic/5.45@#b83a50ad9e90a08cfcf7c1b41f6c8b14
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 46c5614libmagic/5.45@#2e907e14ca856d22ff2c38bb6ce29c38
|
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
10a5bc3
to
57f2e7e
Compare
This comment has been minimized.
This comment has been minimized.
class LibmagicConan(ConanFile): | ||
name = "libmagic" | ||
description = "Magic number recognition library - detect files with data in particular fixed formats." | ||
license = "DocumentRef-COPYING:LicenseRef-BSD-2-Clause-File" # Modified BSD 2-Clause that states no restrictions on US export |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm inclined to think that the DocumenRef-
portion should indicate the library or project name instead of the specific file, i.e. DocumentRef-file
instead of DocumentRef-COPYING
. This fits better with the example in D.3 Simple license expressions. I'm not sure, but I kind of get that feeling this is supposed to be a reference to an SPDX document that we create, i.e. like the SPDXJSONExample-v2.2.spdx.json, but I don't think anyone has done something like that on CCI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RubenRBS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked it time ago: https://opensource.stackexchange.com/a/14309/31147
Co-authored-by: Jordan Williams <jordan@jwillikers.com>
Co-authored-by: Jordan Williams <jordan@jwillikers.com>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, I just would like to use the official repo for download and keep Github as mirror.
Conan v1 pipeline ✔️All green in build 14 (
Conan v2 pipeline ✔️
All green in build 14 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@valgur Do you have a clue if we can somehow port the package to Windows? |
@marxin It's definitely doable, but it will probably require Windows support to be added to the |
Specify library name and version: libmagic/5.45: https://github.com/file/file
Required by