Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmagic: add new recipe #19508

Merged
merged 17 commits into from
Nov 13, 2023
Merged

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Aug 30, 2023

Specify library name and version: libmagic/5.45: https://github.com/file/file

Required by

Packaging status

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit a7f9f62
libmagic/5.45@#b83a50ad9e90a08cfcf7c1b41f6c8b14
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libmagic.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur valgur mentioned this pull request Aug 31, 2023
4 tasks
@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 46c5614
libmagic/5.45@#2e907e14ca856d22ff2c38bb6ce29c38
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libmagic.1.dylib, libmagic.dylib

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Oct 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@AbrilRBS AbrilRBS self-assigned this Oct 17, 2023
@stale stale bot removed the stale label Oct 17, 2023
recipes/libmagic/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libmagic/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libmagic/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libmagic/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@valgur valgur force-pushed the libmagic/new-recipe branch from 10a5bc3 to 57f2e7e Compare October 24, 2023 19:24
@conan-center-bot

This comment has been minimized.

recipes/libmagic/all/conanfile.py Outdated Show resolved Hide resolved
class LibmagicConan(ConanFile):
name = "libmagic"
description = "Magic number recognition library - detect files with data in particular fixed formats."
license = "DocumentRef-COPYING:LicenseRef-BSD-2-Clause-File" # Modified BSD 2-Clause that states no restrictions on US export
Copy link
Contributor

@jwillikers jwillikers Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined to think that the DocumenRef- portion should indicate the library or project name instead of the specific file, i.e. DocumentRef-file instead of DocumentRef-COPYING. This fits better with the example in D.3 Simple license expressions. I'm not sure, but I kind of get that feeling this is supposed to be a reference to an SPDX document that we create, i.e. like the SPDXJSONExample-v2.2.spdx.json, but I don't think anyone has done something like that on CCI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RubenRBS

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recipes/libmagic/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libmagic/all/conanfile.py Outdated Show resolved Hide resolved
valgur and others added 3 commits November 1, 2023 15:35
Co-authored-by: Jordan Williams <jordan@jwillikers.com>
Co-authored-by: Jordan Williams <jordan@jwillikers.com>
@conan-center-bot

This comment has been minimized.

@uilianries uilianries self-assigned this Nov 6, 2023
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I just would like to use the official repo for download and keep Github as mirror.

recipes/libmagic/all/conandata.yml Outdated Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 14 (f7b609577c20e3f1af6295c1e9bc18b1046bab31):

  • libmagic/5.45:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 14 (f7b609577c20e3f1af6295c1e9bc18b1046bab31):

  • libmagic/5.45:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 0659c33 into conan-io:master Nov 13, 2023
5 checks passed
@marxin
Copy link

marxin commented Jan 5, 2024

@valgur Do you have a clue if we can somehow port the package to Windows?

@valgur
Copy link
Contributor Author

valgur commented Jan 5, 2024

@marxin It's definitely doable, but it will probably require Windows support to be added to the tre package first. Vcpkg has Windows support available (via copious amounts of patching) for both recipes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants