Librdkafka/openssl patch/all

[KevDi]

Specify library name and version: librdkafka/all

Starting from librdkafka Version 1.8.0 the following pragma calls for openssl where added librdkafka/src/rdkafka_ssl.c

#pragma comment(lib, "libcrypto.lib")
#pragma comment(lib, "libssl.lib")

On a Debug Build this causes problems, because Openssl builds the Debug Libraries with an additional d (libcryptod.lib/libssld.lib). Linking the Program then fails because it won't find the correct libraries.

Adding these with the correct ending fixes this.
I also opened a PR on the Librdkafka Project with those changes but i'm not sure if they will be added.

---

• I've read the contributing guidelines.
• I've used a recent Conan client version close to the currently deployed.
• I've tried at least one configuration locally with the conan-center hook activated.

[ghost]

I detected other pull requests that are modifying librdkafka/all recipe:

• librdkafka: add version 2.3.0, make libcurl version ranges #20806
• librdkafka: fix Visual Studio Debug ssl >= 1.8.0 #17894

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[KevDi]

As @ericLemanissierBot mentioned there is another PR fixing this Problem. The question is what would be the best way? Adding the additional Pragmas or just replacing them like in the PR #17894

[conan-center-bot]

Conan v1 pipeline ✔️

All green in build 6 (06e973a2767c0ec485eb80cd334ef4d21d796cf2):

• librdkafka/1.9.2:
  All packages built successfully! (All logs)

• librdkafka/1.8.2:
  All packages built successfully! (All logs)

• librdkafka/2.0.2:
  All packages built successfully! (All logs)

• librdkafka/1.9.1:
  All packages built successfully! (All logs)

• librdkafka/1.8.0:
  All packages built successfully! (All logs)

• librdkafka/1.6.1:
  All packages built successfully! (All logs)

• librdkafka/1.7.0:
  All packages built successfully! (All logs)

• librdkafka/1.6.0:
  All packages built successfully! (All logs)

• librdkafka/1.5.3:
  All packages built successfully! (All logs)

[AbrilRBS]

I'm retriggering the build in v2 as it failed for a networking reason, thanks for your patience while we processed the rest of the PR backlog :)

[KevDi]

@RubenRBS 👍 and is this fix as it is ok or is the one mentioned above where the replace is done in python a better solution? I also made a pr at the librdkafka project with those changes so maybe if it gets accepted this patches are not needed then anymore. But we will see 😃☺️

[AbrilRBS]

@RubenRBS 👍 and is this fix as it is ok or is the one mentioned above where the replace is done in python a better solution? I also made a pr at the librdkafka project with those changes so maybe if it gets accepted this patches are not needed then anymore. But we will see 😃☺️

Oh my @KevDi sorry about the radio silence, I totally dropped the ball on this one and did not see the mention notification until now, so I didn't circle back to the PR until now

Do you have a link to the PR you mention you submitted upstream? Having backport links usually helps a lot for future maintenance

[KevDi]

@RubenRBS this is the other PR which deals with this problem #17894

[AbrilRBS]

Oh sorry I didnt make myself clear at all, I was asking about the PR you mentioned opening upstream

[KevDi]

Okay sorry you mean the PR on the librdkafka Project. Here it is: Added Pragmas for the Debug Libs from Openssl

[KevDi]

@RubenRBS is this PR still considered to be implemented? If so i would try to update it to the latest version. Because it seems the problem still exists. And from librdkafka side there is still no feedback on that topic.

[KevDi]

not needed anymore