librdkafka: fix Visual Studio Debug ssl >= 1.8.0

[sourcedelica]

Specify library name and version: librdkafka/1.8.0

Fixes #17879

• I've read the contributing guidelines.
• I've used a recent Conan client version close to the currently deployed.
• I've tried at least one configuration locally with the conan-center hook activated.

[CLAassistant]

All committers have signed the CLA.

[ghost]

I detected other pull requests that are modifying librdkafka/all recipe:

• librdkafka: add version 2.3.0, make libcurl version ranges #20806
• Librdkafka/openssl patch/all #19496

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[sourcedelica]

Bumping this so it’s not automatically closed. Let me know if it should be closed.

[AbrilRBS]

Hello @sourcedelica - First of all, sorry about the delay on getting back to you on this PR. It got lost among the rest of the PR submissions as it got mislabeled internally in our GitHub project, thanks a lot for your patience on this one.

As for the PR changes themselves, they seem to look good! Reading the original issue you submitted, seems like this might in fact be the only way forward to fix the issue, but will check around just in case.

Also, please remember to sign the CLA for the PR to be mergeable once approved, thanks!

[uilianries]

The is_msvc is now part of Conan tools, so we no longer need to maintain it in the recipe 😄

[uilianries]

LGTM

[sourcedelica]

I'll rebase this on the weekend.

I'm not sure what that failed check (c3i/conan-v2/pr-merge) is. When I click details it takes me to a 403 Forbidden nginx page.

[conan-center-bot]

Conan v1 pipeline ✔️

All green in build 8 (eb9c0a7302605243df87b36ea5944c5100228a5e):

• librdkafka/2.3.0:
  All packages built successfully! (All logs)

• librdkafka/2.2.0:
  All packages built successfully! (All logs)

• librdkafka/2.0.2:
  All packages built successfully! (All logs)

• librdkafka/1.9.2:
  All packages built successfully! (All logs)

---

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (eb9c0a7302605243df87b36ea5944c5100228a5e):

• librdkafka/2.3.0:
  All packages built successfully! (All logs)

• librdkafka/2.2.0:
  All packages built successfully! (All logs)

• librdkafka/2.0.2:
  All packages built successfully! (All logs)

• librdkafka/1.9.2:
  All packages built successfully! (All logs)

[sourcedelica]

Awesome, thanks @uilianries!

[SpaceIm]

It's fragile. What will happen if we decide to rename these lib names (this d postfix shouldn't have been added to openssl libs in openssl recipe, there were many discussions about this issue).

You should refer to cpp_info.libs values of openssl components, so that it can be future proof.

        if Version(self.version) >= "1.8.0" and is_msvc(self) and self.options.get_safe("ssl"):
            rdkafka_ssl_path = os.path.join(self.source_folder, "src", "rdkafka_ssl.c")
            openssl_cpp_info = self.dependencies["openssl"].cpp_info
            crypto_lib = openssl_cpp_info.components["crypto"].libs[0]
            ssl_lib = openssl_cpp_info.components["ssl"].libs[0]
            replace_in_file(self, rdkafka_ssl_path, "libcrypto.lib", f"{crypto_lib}.lib")
            replace_in_file(self, rdkafka_ssl_path, "libssl.lib", f"{ssl_lib}.lib")