openssh/9.1p1: Added openssh recipe

[klausholstjacobsen]

openssh/9.1p1
openssh/8.1p1

Added recipe!

---

• I've read the contributing guidelines.
• I've used a recent Conan client version close to the currently deployed.
• I've tried at least one configuration locally with the conan-center hook activated.

[AbrilRBS]

Thanks a lot! I have a few comments, but the overall structure of the recipe looks good, thank you as always :)

[AbrilRBS]

Hi! Sorry about the delay - the PR fell thru the cracks and got lost on the sea of PRs

The good news is that the PR looks great, one minor thing remaining before merging - feel free to ping me directly once that's done so that I can approve asap :)

[klausholstjacobsen]

@RubenRBS your suggestion is committed! Have a nice weekend!

[valgur]

LGTM, but I would adjust the negative option values a bit to match other recipes better.

[franramirez688]

Hi @klausholstjacobsen

Thanks a lot for adding this recipe, and sorry for the long delay in reviewing this PR.

I just added one commit to simplify a couple of things, but it looks great! 👏

Before approving, I have a question. I just tried this command and got some errors in macOS Sonoma 14.4.1 (failed with both *:shared=True and False):

$ conan create . --version 9.6p1 --build missing -o with_libcrypto="libressl"
. . . 
cc -m64 -O3 -pipe -Wunknown-warning-option -Qunused-arguments -Wall -Wextra -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-parameter -Wno-unused-result -Wmisleading-indentation -Wbitwise-instead-of-logical -fno-strict-aliasing -mretpoline -D_FORTIFY_SOURCE=2 -ftrapv -fzero-call-used-regs=used -ftrivial-auto-var-init=zero -fno-builtin-memset -fstack-protector-strong   -fPIC -I. -I.. -I/Users/conanuser/.conan2/p/b/opensc8a0037d6a765/b/src/openbsd-compat -I/Users/conanuser/.conan2/p/b/opensc8a0037d6a765/b/src/openbsd-compat/.. -I/Users/conanuser/.conan2/p/b/libreef807320845de/p/include  -I/Users/conanuser/.conan2/p/b/libreef807320845de/p/include -I/Users/conanuser/.conan2/p/b/zlibf6519252f237d/p/include -DNDEBUG -DHAVE_CONFIG_H -c /Users/conanuser/.conan2/p/b/opensc8a0037d6a765/b/src/openbsd-compat/fmt_scaled.c
/Users/conanuser/.conan2/p/b/opensc8a0037d6a765/b/src/openbsd-compat/xcrypt.c:88:4: error: call to undeclared function 'explicit_bzero'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                        explicit_bzero(passwd, strlen(passwd));
                        ^
1 error generated.
make[1]: *** [xcrypt.o] Error 1
make[1]: *** Waiting for unfinished jobs....
/Users/conanuser/.conan2/p/b/opensc8a0037d6a765/b/src/openbsd-compat/bcrypt_pbkdf.c:108:2: error: call to undeclared function 'explicit_bzero'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        explicit_bzero(ciphertext, sizeof(ciphertext));
        ^
/Users/conanuser/.conan2/p/b/opensc8a0037d6a765/b/src/openbsd-compat/bcrypt_pbkdf.c:177:2: error: call to undeclared function 'freezero'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        freezero(countsalt, saltlen + 4);
        ^
/Users/conanuser/.conan2/p/b/opensc8a0037d6a765/b/src/openbsd-compat/bcrypt_pbkdf.c:178:2: error: call to undeclared function 'explicit_bzero'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        explicit_bzero(out, sizeof(out));
        ^
3 errors generated.
make[1]: *** [bcrypt_pbkdf.o] Error 1
make: *** [openbsd-compat/libopenbsd-compat.a] Error 2

openssh/9.6p1: ERROR:
Package '9831a80989c890ca8957350d5a90e23b88ab109c' build failed
openssh/9.6p1: WARN: Build folder /Users/conanuser/.conan2/p/b/opensc8a0037d6a765/b/build-release
ERROR: openssh/9.6p1: Error in build() method, line 110
	autotools.make()
	ConanException: Error 2 while executing

Could it be a bug in openssh using libressl in macOS? Maybe related to this openssh/openssh-portable#203 ??

For the record, I just tried it in Linux and it works fine.

[jwillikers]

@franramirez688 I recently worked with the util-linux project to fix a usage of explicit_bzero on macOS that produced the same error. That symbol isn't available on macOS. It appears that their Autotools script checks for this function and defines its own if it is not available. Something must be off in the build system regarding this.

[franramirez688]

@franramirez688 I recently worked with the util-linux project to fix a usage of explicit_bzero on macOS that produced the same error. That symbol isn't available on macOS. It appears that their Autotools script checks for this function and defines its own if it is not available. Something must be off in the build system regarding this.

Thanks @jwillikers for the explanation. Given that, would it make sense to add a validate step for raising an invalid configuration exception when using with_libcrypto == "libressl" and macOS?

[jwillikers]

@franramirez688 The configure output should note whether explicit_bzero was detected or not. In CI, I see checking for explicit_bzero... no. Do you see that as well? I don't think this issue has anything to do with libressl, since OpenSSH Portable should be declaring and defining this function as needed on macOS. It's required regardless of the implementation of libcrypto, unless OpenSSL is declaring the function.

[jwillikers]

@franramirez688 Perhaps explicit_bzero is being picked up from the libressl project in the configure checks? I wonder if this was fixed in libressl/portable#961.

[franramirez688]

@franramirez688 Perhaps explicit_bzero is being picked up from the libressl project in the configure checks? I wonder if this was fixed in libressl/portable#961.

@jwillikers thanks for that one. Indeed, it was the key point. Using libressl/3.9.1 (#23325), that problem would be solved 👏

Waiting for your PR to be merged, so we can add it directly here.

[conan-center-bot]

Conan v1 pipeline ✔️

All green in build 6 (2692da4bfed12374728a6dd447aa03863851156f):

• openssh/9.6p1:
  All packages built successfully! (All logs)

• openssh/9.1p1:
  All packages built successfully! (All logs)

---

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (2692da4bfed12374728a6dd447aa03863851156f):

• openssh/9.6p1:
  All packages built successfully! (All logs)

• openssh/9.1p1:
  All packages built successfully! (All logs)